Skip to content

Commit d106f96

Browse files
krzkandersson
authored andcommitted
arm64: dts: qcom: ipq5018: Correct USB DWC3 wrapper interrupts
Interrupts for DWC3 node were completely mixed up - SPI interrupt 62 is not listed in reference manual at all. It was also causing dtbs_check warnings: ipq5018-rdp432-c2.dtb: usb@8af8800 (qcom,ipq5018-dwc3): interrupt-names:0: 'pwr_event' was expected ipq5018-rdp432-c2.dtb: usb@8af8800 (qcom,ipq5018-dwc3): interrupt-names: ['hs_phy_irq'] is too short Warning itself was introduced by commit 53c6d85 ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding"), but this was trying to bring sanity to the interrupts overall, although did a mistake for IPQ5018. IPQ5018 does not have QUSB2 PHY and its interrupts should rather match ones used in IPQ5332. Correct it by using interrupts matching the bindings and reference manual. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Tested-by: George Moussalem <george.moussalem@outlook.com> Link: https://lore.kernel.org/r/20260106185123.19929-3-krzysztof.kozlowski@oss.qualcomm.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 4f791e0 commit d106f96

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

arch/arm64/boot/dts/qcom/ipq5018.dtsi

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -571,8 +571,12 @@
571571
compatible = "qcom,ipq5018-dwc3", "qcom,dwc3";
572572
reg = <0x08af8800 0x400>;
573573

574-
interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
575-
interrupt-names = "hs_phy_irq";
574+
interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
575+
<GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
576+
<GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
577+
interrupt-names = "pwr_event",
578+
"dp_hs_phy_irq",
579+
"dm_hs_phy_irq";
576580

577581
clocks = <&gcc GCC_USB0_MASTER_CLK>,
578582
<&gcc GCC_SYS_NOC_USB0_AXI_CLK>,

0 commit comments

Comments
 (0)