ALSA: oxfw: make read-only const array models static

ColinIanKing · tiwai · commit d17f0ce9a9ee · 2023-06-28T11:42:29.000+02:00
Don't populate the const array on the stack, instead make it static. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Link: https://lore.kernel.org/r/20230627113253.700065-1-colin.i.king@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c
@@ -44,7 +44,7 @@ struct compat_info {
 
 static bool detect_loud_models(struct fw_unit *unit)
 {
-	const char *const models[] = {
+	static const char *const models[] = {
 		"Onyxi",
 		"Onyx-i",
 		"Onyx 1640i",

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ struct compat_info {`
`44`	`44`
`45`	`45`	`static bool detect_loud_models(struct fw_unit *unit)`
`46`	`46`	`{`
`47`		`- const char *const models[] = {`
	`47`	`+ static const char *const models[] = {`
`48`	`48`	`"Onyxi",`
`49`	`49`	`"Onyx-i",`
`50`	`50`	`"Onyx 1640i",`