Skip to content

Commit d1a196e

Browse files
tobluxij-intel
authored andcommitted
platform/x86: dell-wmi-sysman: Don't hex dump plaintext password data
set_new_password() hex dumps the entire buffer, which contains plaintext password data, including current and new passwords. Remove the hex dump to avoid leaking credentials. Fixes: e8a60aa ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Link: https://patch.msgid.link/20260303113050.58127-2-thorsten.blum@linux.dev Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 3350c2b commit d1a196e

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ int set_new_password(const char *password_type, const char *new)
9393
if (ret < 0)
9494
goto out;
9595

96-
print_hex_dump_bytes("set new password data: ", DUMP_PREFIX_NONE, buffer, buffer_size);
9796
ret = call_password_interface(wmi_priv.password_attr_wdev, buffer, buffer_size);
9897
/* on success copy the new password to current password */
9998
if (!ret)

0 commit comments

Comments
 (0)