drm/msm/dp: fix incorrect function prototype of dp_debug_get()

Abhinav Kumar · robclark · commit d1ea91492585 · 2020-09-25T20:31:06.000-07:00
Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning. Also add prototype for msm_dp_debugfs_init() for fixing compilation issue with other defconfigs. changes in v2: - add prototype for msm_dp_debugfs_init() Fixes: f913454 ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org> Signed-off-by: Rob Clark <robdclark@chromium.org>
diff --git a/drivers/gpu/drm/msm/dp/dp_debug.h b/drivers/gpu/drm/msm/dp/dp_debug.h
@@ -60,7 +60,7 @@ void dp_debug_put(struct dp_debug *dp_debug);
 static inline
 struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
 		struct dp_usbpd *usbpd, struct dp_link *link,
-		struct drm_connector **connector)
+		struct drm_connector **connector, struct drm_minor *minor)
 {
 	return ERR_PTR(-EINVAL);
 }
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
@@ -434,6 +434,11 @@ static inline void msm_dp_irq_postinstall(struct msm_dp *dp_display)
 {
 }
 
+static inline void msm_dp_debugfs_init(struct msm_dp *dp_display,
+		struct drm_minor *minor)
+{
+}
+
 #endif
 
 void __init msm_mdp_register(void);

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ void dp_debug_put(struct dp_debug *dp_debug);`
`60`	`60`	`static inline`
`61`	`61`	`struct dp_debug dp_debug_get(struct device dev, struct dp_panel *panel,`
`62`	`62`	`struct dp_usbpd usbpd, struct dp_link link,`
`63`		`- struct drm_connector **connector)`
	`63`	`+ struct drm_connector *connector, struct drm_minor minor)`
`64`	`64`	`{`
`65`	`65`	`return ERR_PTR(-EINVAL);`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -434,6 +434,11 @@ static inline void msm_dp_irq_postinstall(struct msm_dp *dp_display)`
`434`	`434`	`{`
`435`	`435`	`}`
`436`	`436`
	`437`	`+static inline void msm_dp_debugfs_init(struct msm_dp *dp_display,`
	`438`	`+ struct drm_minor *minor)`
	`439`	`+{`
	`440`	`+}`
	`441`	`+`
`437`	`442`	`#endif`
`438`	`443`
`439`	`444`	`void __init msm_mdp_register(void);`