platform/x86: thinkpad_acpi: Fix a memory leak of EFCH MMIO resource

jdelvare · jwrdegoede · commit d2f33f0c3ad7 · 2022-06-27T09:38:56.000+02:00
Unlike release_mem_region(), a call to release_resource() does not free the resource, so it has to be freed explicitly to avoid a memory leak. Signed-off-by: Jean Delvare <jdelvare@suse.de> Fixes: 455cd86 ("platform/x86: thinkpad_acpi: Add a s2idle resume quirk for a number of laptops") Cc: Mario Limonciello <mario.limonciello@amd.com> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Mark Gross <markgross@kernel.org> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20220621155511.5b266395@endymion.delvare Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
@@ -4529,6 +4529,7 @@ static void thinkpad_acpi_amd_s2idle_restore(void)
 	iounmap(addr);
 cleanup_resource:
 	release_resource(res);
+	kfree(res);
 }
 
 static struct acpi_s2idle_dev_ops thinkpad_acpi_s2idle_dev_ops = {

Original file line number	Diff line number	Diff line change
`@@ -4529,6 +4529,7 @@ static void thinkpad_acpi_amd_s2idle_restore(void)`
`4529`	`4529`	`iounmap(addr);`
`4530`	`4530`	`cleanup_resource:`
`4531`	`4531`	`release_resource(res);`
	`4532`	`+ kfree(res);`
`4532`	`4533`	`}`
`4533`	`4534`
`4534`	`4535`	`static struct acpi_s2idle_dev_ops thinkpad_acpi_s2idle_dev_ops = {`