Skip to content

Commit d31e038

Browse files
olsajiriborkmann
authored andcommitted
bpf: Fix sparse warnings in kprobe_multi_resolve_syms
Adding missing __user tags to fix sparse warnings: kernel/trace/bpf_trace.c:2370:34: warning: incorrect type in argument 2 (different address spaces) kernel/trace/bpf_trace.c:2370:34: expected void const [noderef] __user *from kernel/trace/bpf_trace.c:2370:34: got void const *usyms kernel/trace/bpf_trace.c:2376:51: warning: incorrect type in argument 2 (different address spaces) kernel/trace/bpf_trace.c:2376:51: expected char const [noderef] __user *src kernel/trace/bpf_trace.c:2376:51: got char const * kernel/trace/bpf_trace.c:2443:49: warning: incorrect type in argument 1 (different address spaces) kernel/trace/bpf_trace.c:2443:49: expected void const *usyms kernel/trace/bpf_trace.c:2443:49: got void [noderef] __user *[assigned] usyms Fixes: 0dcac27 ("bpf: Add multi kprobe link") Reported-by: Alexei Starovoitov <ast@kernel.org> Reported-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20220330110510.398558-1-jolsa@kernel.org
1 parent 522574f commit d31e038

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

kernel/trace/bpf_trace.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2349,11 +2349,11 @@ kprobe_multi_link_handler(struct fprobe *fp, unsigned long entry_ip,
23492349
}
23502350

23512351
static int
2352-
kprobe_multi_resolve_syms(const void *usyms, u32 cnt,
2352+
kprobe_multi_resolve_syms(const void __user *usyms, u32 cnt,
23532353
unsigned long *addrs)
23542354
{
23552355
unsigned long addr, size;
2356-
const char **syms;
2356+
const char __user **syms;
23572357
int err = -ENOMEM;
23582358
unsigned int i;
23592359
char *func;

0 commit comments

Comments
 (0)