Skip to content

Commit d33976b

Browse files
committed
hwspinlock: omap: Discard pm_runtime_put() return value
Failing driver probe due to pm_runtime_put() returning a negative value is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. It also happens when the kernel has been configured with CONFIG_PM unset. Accordingly, update omap_hwspinlock_probe() to simply discard the return value of pm_runtime_put(). This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Bjorn Andersson <andersson@kernel.org> Link: https://patch.msgid.link/883243465.0ifERbkFSE@rafael.j.wysocki
1 parent 7b8de72 commit d33976b

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/hwspinlock/omap_hwspinlock.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,7 @@ static int omap_hwspinlock_probe(struct platform_device *pdev)
101101
* runtime PM will make sure the clock of this module is
102102
* enabled again iff at least one lock is requested
103103
*/
104-
ret = pm_runtime_put(&pdev->dev);
105-
if (ret < 0)
106-
return ret;
104+
pm_runtime_put(&pdev->dev);
107105

108106
/* one of the four lsb's must be set, and nothing else */
109107
if (hweight_long(i & 0xf) != 1 || i > 8)

0 commit comments

Comments
 (0)