Skip to content

Commit d484d0f

Browse files
Uwe Kleine-Königdtor
authored andcommitted
Input: ams_delta_serio - convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230920125829.1478827-31-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent fb4f4f3 commit d484d0f

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/input/serio/ams_delta_serio.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,18 +173,16 @@ static int ams_delta_serio_init(struct platform_device *pdev)
173173
return 0;
174174
}
175175

176-
static int ams_delta_serio_exit(struct platform_device *pdev)
176+
static void ams_delta_serio_exit(struct platform_device *pdev)
177177
{
178178
struct ams_delta_serio *priv = platform_get_drvdata(pdev);
179179

180180
serio_unregister_port(priv->serio);
181-
182-
return 0;
183181
}
184182

185183
static struct platform_driver ams_delta_serio_driver = {
186184
.probe = ams_delta_serio_init,
187-
.remove = ams_delta_serio_exit,
185+
.remove_new = ams_delta_serio_exit,
188186
.driver = {
189187
.name = DRIVER_NAME
190188
},

0 commit comments

Comments
 (0)