Skip to content

Commit d4a5b36

Browse files
shakeelbakpm00
authored andcommitted
mm: ratelimit stat flush from workingset shrinker
One of our workloads (Postgres 14 + sysbench OLTP) regressed on newer upstream kernel and on further investigation, it seems like the cause is the always synchronous rstat flush in the count_shadow_nodes() added by the commit f82e6bf ("mm: memcg: use rstat for non-hierarchical stats"). On further inspection it seems like we don't really need accurate stats in this function as it was already approximating the amount of appropriate shadow entries to keep for maintaining the refault information. Since there is already 2 sec periodic rstat flush, we don't need exact stats here. Let's ratelimit the rstat flush in this code path. Link: https://lkml.kernel.org/r/20231228073055.4046430-1-shakeelb@google.com Fixes: f82e6bf ("mm: memcg: use rstat for non-hierarchical stats") Signed-off-by: Shakeel Butt <shakeelb@google.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Yosry Ahmed <yosryahmed@google.com> Cc: Yu Zhao <yuzhao@google.com> Cc: Michal Hocko <mhocko@suse.com> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: Muchun Song <songmuchun@bytedance.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 63b85ac commit d4a5b36

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

mm/workingset.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ static unsigned long count_shadow_nodes(struct shrinker *shrinker,
680680
struct lruvec *lruvec;
681681
int i;
682682

683-
mem_cgroup_flush_stats(sc->memcg);
683+
mem_cgroup_flush_stats_ratelimited(sc->memcg);
684684
lruvec = mem_cgroup_lruvec(sc->memcg, NODE_DATA(sc->nid));
685685
for (pages = 0, i = 0; i < NR_LRU_LISTS; i++)
686686
pages += lruvec_page_state_local(lruvec,

0 commit comments

Comments
 (0)