ext4: fix boolreturn.cocci warnings in fs/ext4/name.c

Jing Yangyang · tytso · commit d4ffeeb7315d · 2021-11-04T10:33:25.000-04:00
Return statements in functions returning bool should use true/false instead of 1/0. ./fs/ext4/namei.c:1441:12-13:WARNING:return of 0/1 in function 'ext4_match' with return type bool Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20210824055543.58718-1-deng.changcheng@zte.com.cn Signed-off-by: Theodore Ts'o <tytso@mit.edu>
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
@@ -1439,7 +1439,7 @@ static bool ext4_match(struct inode *parent,
 					fname->hinfo.minor_hash !=
 						EXT4_DIRENT_MINOR_HASH(de)) {
 
-					return 0;
+					return false;
 				}
 			}
 			return !ext4_ci_compare(parent, &cf, de->name,

Original file line number	Diff line number	Diff line change
`@@ -1439,7 +1439,7 @@ static bool ext4_match(struct inode *parent,`
`1439`	`1439`	`fname->hinfo.minor_hash !=`
`1440`	`1440`	`EXT4_DIRENT_MINOR_HASH(de)) {`
`1441`	`1441`
`1442`		`- return 0;`
	`1442`	`+ return false;`
`1443`	`1443`	`}`
`1444`	`1444`	`}`
`1445`	`1445`	`return !ext4_ci_compare(parent, &cf, de->name,`