Skip to content

Commit d564fa1

Browse files
vladimirolteanarndb
authored andcommitted
asm-generic/io.h: suppress endianness warnings for readq() and writeq()
Commit c1d55d5 ("asm-generic/io.h: Fix sparse warnings on big-endian architectures") missed fixing the 64-bit accessors. Arnd explains in the attached link why the casts are necessary, even if __raw_readq() and __raw_writeq() do not take endian-specific types. Link: https://lore.kernel.org/lkml/9105d6fc-880b-4734-857d-e3d30b87ccf6@app.fastmail.com/ Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
1 parent fe15c26 commit d564fa1

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • include/asm-generic

include/asm-generic/io.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ static inline u64 readq(const volatile void __iomem *addr)
236236

237237
log_read_mmio(64, addr, _THIS_IP_, _RET_IP_);
238238
__io_br();
239-
val = __le64_to_cpu(__raw_readq(addr));
239+
val = __le64_to_cpu((__le64 __force)__raw_readq(addr));
240240
__io_ar(val);
241241
log_post_read_mmio(val, 64, addr, _THIS_IP_, _RET_IP_);
242242
return val;
@@ -287,7 +287,7 @@ static inline void writeq(u64 value, volatile void __iomem *addr)
287287
{
288288
log_write_mmio(value, 64, addr, _THIS_IP_, _RET_IP_);
289289
__io_bw();
290-
__raw_writeq(__cpu_to_le64(value), addr);
290+
__raw_writeq((u64 __force)__cpu_to_le64(value), addr);
291291
__io_aw();
292292
log_post_write_mmio(value, 64, addr, _THIS_IP_, _RET_IP_);
293293
}

0 commit comments

Comments
 (0)