Skip to content

Commit d58bfcd

Browse files
armurthyjnikula
authored andcommitted
drm/i915/display: Print useful information on error
For modifier not supporting async flip, print the modifier and display version. Helps in reading the error message. v2: Reframe the error message (Jani) Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230602022157.221225-1-arun.r.murthy@intel.com
1 parent 619a06d commit d58bfcd

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6012,8 +6012,9 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in
60126012
*/
60136013
if (DISPLAY_VER(i915) < 12) {
60146014
drm_dbg_kms(&i915->drm,
6015-
"[PLANE:%d:%s] Modifier does not support async flips\n",
6016-
plane->base.base.id, plane->base.name);
6015+
"[PLANE:%d:%s] Modifier 0x%llx does not support async flip on display ver %d\n",
6016+
plane->base.base.id, plane->base.name,
6017+
new_plane_state->hw.fb->modifier, DISPLAY_VER(i915));
60176018
return -EINVAL;
60186019
}
60196020
break;
@@ -6025,8 +6026,9 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in
60256026
break;
60266027
default:
60276028
drm_dbg_kms(&i915->drm,
6028-
"[PLANE:%d:%s] Modifier does not support async flips\n",
6029-
plane->base.base.id, plane->base.name);
6029+
"[PLANE:%d:%s] Modifier 0x%llx does not support async flip\n",
6030+
plane->base.base.id, plane->base.name,
6031+
new_plane_state->hw.fb->modifier);
60306032
return -EINVAL;
60316033
}
60326034

0 commit comments

Comments
 (0)