qlcnic: Fix fall-through warnings for Clang

GustavoARSilva · GustavoARSilva · commit d66aea44b0ac · 2021-05-17T19:24:57.000-05:00
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding a break and a goto statements instead of just letting the code fall through to the next case. Link: KSPP#115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
@@ -1390,6 +1390,7 @@ static int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int ma
 			break;
 		case QLCNIC_RESPONSE_DESC:
 			qlcnic_handle_fw_message(desc_cnt, consumer, sds_ring);
+			goto skip;
 		default:
 			goto skip;
 		}
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -3455,6 +3455,7 @@ qlcnic_fwinit_work(struct work_struct *work)
 			adapter->fw_wait_cnt = 0;
 			return;
 		}
+		break;
 	case QLCNIC_DEV_FAILED:
 		break;
 	default:

Original file line number	Diff line number	Diff line change
`@@ -1390,6 +1390,7 @@ static int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int ma`
`1390`	`1390`	`break;`
`1391`	`1391`	`case QLCNIC_RESPONSE_DESC:`
`1392`	`1392`	`qlcnic_handle_fw_message(desc_cnt, consumer, sds_ring);`
	`1393`	`+ goto skip;`
`1393`	`1394`	`default:`
`1394`	`1395`	`goto skip;`
`1395`	`1396`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3455,6 +3455,7 @@ qlcnic_fwinit_work(struct work_struct *work)`
`3455`	`3455`	`adapter->fw_wait_cnt = 0;`
`3456`	`3456`	`return;`
`3457`	`3457`	`}`
	`3458`	`+ break;`
`3458`	`3459`	`case QLCNIC_DEV_FAILED:`
`3459`	`3460`	`break;`
`3460`	`3461`	`default:`