Skip to content

Commit d6b862f

Browse files
Uwe Kleine-Königmathieupoirier
authored andcommitted
remoteproc: pru: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230504194453.1150368-9-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 141adf2 commit d6b862f

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/remoteproc/pru_rproc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,14 +1071,12 @@ static int pru_rproc_probe(struct platform_device *pdev)
10711071
return 0;
10721072
}
10731073

1074-
static int pru_rproc_remove(struct platform_device *pdev)
1074+
static void pru_rproc_remove(struct platform_device *pdev)
10751075
{
10761076
struct device *dev = &pdev->dev;
10771077
struct rproc *rproc = platform_get_drvdata(pdev);
10781078

10791079
dev_dbg(dev, "%s: removing rproc %s\n", __func__, rproc->name);
1080-
1081-
return 0;
10821080
}
10831081

10841082
static const struct pru_private_data pru_data = {
@@ -1126,7 +1124,7 @@ static struct platform_driver pru_rproc_driver = {
11261124
.suppress_bind_attrs = true,
11271125
},
11281126
.probe = pru_rproc_probe,
1129-
.remove = pru_rproc_remove,
1127+
.remove_new = pru_rproc_remove,
11301128
};
11311129
module_platform_driver(pru_rproc_driver);
11321130

0 commit comments

Comments
 (0)