Skip to content

Commit d6df4ab

Browse files
Bartosz Golaszewskilinusw
authored andcommitted
pinctrl: meson: amlogic-a4: mark the GPIO controller as sleeping
The GPIO controller is configured as non-sleeping but it uses generic pinctrl helpers which use a mutex for synchronization. This will cause lockdep splats when used together with shared GPIOs going through the GPIO shared proxy driver. Fixes: 6e9be3a ("pinctrl: Add driver support for Amlogic SoCs") Cc: stable@vger.kernel.org Reported-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Closes: https://lore.kernel.org/all/CAFBinCAc7CO8gfNQakCu3LfkYXuyTd2iRpMRm8EKXSL0mwOnJw@mail.gmail.com/ Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Linus Walleij <linusw@kernel.org>
1 parent d184b5f commit d6df4ab

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pinctrl/meson/pinctrl-amlogic-a4.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ static const struct gpio_chip aml_gpio_template = {
893893
.direction_input = aml_gpio_direction_input,
894894
.direction_output = aml_gpio_direction_output,
895895
.get_direction = aml_gpio_get_direction,
896-
.can_sleep = false,
896+
.can_sleep = true,
897897
};
898898

899899
static void init_bank_register_bit(struct aml_pinctrl *info,

0 commit comments

Comments
 (0)