regmap: kunit: Replace a kmalloc/kfree() pair with KUnit-managed alloc

rfvirgil · broonie · commit d6f2fd7adcb5 · 2024-04-08T16:38:13.000+01:00
Replace the kmalloc() and kfree() in raw_read_defaults() with a kunit_kmalloc() so that KUnit will free it automatically. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://msgid.link/r/20240408144600.230848-10-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/base/regmap/regmap-kunit.c b/drivers/base/regmap/regmap-kunit.c
@@ -1360,7 +1360,7 @@ static void raw_read_defaults(struct kunit *test)
 		return;
 
 	val_len = sizeof(*rval) * (config.max_register + 1);
-	rval = kmalloc(val_len, GFP_KERNEL);
+	rval = kunit_kmalloc(test, val_len, GFP_KERNEL);
 	KUNIT_ASSERT_TRUE(test, rval != NULL);
 	if (!rval)
 		return;
@@ -1375,8 +1375,6 @@ static void raw_read_defaults(struct kunit *test)
 			KUNIT_EXPECT_EQ(test, def, le16_to_cpu((__force __le16)rval[i]));
 		}
 	}
-
-	kfree(rval);
 }
 
 static void raw_write_read_single(struct kunit *test)

Original file line number	Diff line number	Diff line change
`@@ -1360,7 +1360,7 @@ static void raw_read_defaults(struct kunit *test)`
`1360`	`1360`	`return;`
`1361`	`1361`
`1362`	`1362`	`val_len = sizeof(rval) (config.max_register + 1);`
`1363`		`- rval = kmalloc(val_len, GFP_KERNEL);`
	`1363`	`+ rval = kunit_kmalloc(test, val_len, GFP_KERNEL);`
`1364`	`1364`	`KUNIT_ASSERT_TRUE(test, rval != NULL);`
`1365`	`1365`	`if (!rval)`
`1366`	`1366`	`return;`
`@@ -1375,8 +1375,6 @@ static void raw_read_defaults(struct kunit *test)`
`1375`	`1375`	`KUNIT_EXPECT_EQ(test, def, le16_to_cpu((__force __le16)rval[i]));`
`1376`	`1376`	`}`
`1377`	`1377`	`}`
`1378`		`-`
`1379`		`- kfree(rval);`
`1380`	`1378`	`}`
`1381`	`1379`
`1382`	`1380`	`static void raw_write_read_single(struct kunit *test)`