platform/x86: amd-pmc: uninitialized variable in amd_pmc_s2d_init()

Dan Carpenter · jwrdegoede · commit d713b8d2aa03 · 2022-03-08T16:33:30.000+01:00
The "size" variable can be uninitialized if amd_pmc_send_cmd() fails. Fixes: 3d7d407 ("platform/x86: amd-pmc: Add support for AMD Spill to DRAM STB feature") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20220307141832.GA19660@kili Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
@@ -708,8 +708,9 @@ static const struct pci_device_id pmc_pci_ids[] = {
 
 static int amd_pmc_s2d_init(struct amd_pmc_dev *dev)
 {
-	u32 size, phys_addr_low, phys_addr_hi;
+	u32 phys_addr_low, phys_addr_hi;
 	u64 stb_phys_addr;
+	u32 size = 0;
 
 	/* Spill to DRAM feature uses separate SMU message port */
 	dev->msg_port = 1;

Original file line number	Diff line number	Diff line change
`@@ -708,8 +708,9 @@ static const struct pci_device_id pmc_pci_ids[] = {`
`708`	`708`
`709`	`709`	`static int amd_pmc_s2d_init(struct amd_pmc_dev *dev)`
`710`	`710`	`{`
`711`		`- u32 size, phys_addr_low, phys_addr_hi;`
	`711`	`+ u32 phys_addr_low, phys_addr_hi;`
`712`	`712`	`u64 stb_phys_addr;`
	`713`	`+ u32 size = 0;`
`713`	`714`
`714`	`715`	`/* Spill to DRAM feature uses separate SMU message port */`
`715`	`716`	`dev->msg_port = 1;`