Skip to content

Commit d721b59

Browse files
njavalimartinkpetersen
authored andcommitted
scsi: qla2xxx: Array index may go out of bound
Klocwork reports array 'vha->host_str' of size 16 may use index value(s) 16..19. Use snprintf() instead of sprintf(). Cc: stable@vger.kernel.org Co-developed-by: Bikash Hazarika <bhazarika@marvell.com> Signed-off-by: Bikash Hazarika <bhazarika@marvell.com> Signed-off-by: Nilesh Javali <njavali@marvell.com> Link: https://lore.kernel.org/r/20230607113843.37185-2-njavali@marvell.com Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent eb91eb8 commit d721b59

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/scsi/qla2xxx/qla_os.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5088,7 +5088,8 @@ struct scsi_qla_host *qla2x00_create_host(const struct scsi_host_template *sht,
50885088
}
50895089
INIT_DELAYED_WORK(&vha->scan.scan_work, qla_scan_work_fn);
50905090

5091-
sprintf(vha->host_str, "%s_%lu", QLA2XXX_DRIVER_NAME, vha->host_no);
5091+
snprintf(vha->host_str, sizeof(vha->host_str), "%s_%lu",
5092+
QLA2XXX_DRIVER_NAME, vha->host_no);
50925093
ql_dbg(ql_dbg_init, vha, 0x0041,
50935094
"Allocated the host=%p hw=%p vha=%p dev_name=%s",
50945095
vha->host, vha->hw, vha,

0 commit comments

Comments
 (0)