Skip to content

Commit d73ed58

Browse files
kcxtandersson
authored andcommitted
arm64: dts: qcom: sdm845-db845c: make pcie0_3p3v_dual always-on
This regulator is responsible not just for the PCIe 3.3v rail, but also for 5v VBUS on the left USB port. There is currently no way to correctly model this dependency on the USB controller, as a result when the PCIe driver is not available (for example when in the initramfs) USB is non-functional. Until support is added for modelling this property (likely by referencing it as a supply under a usb-connector node), let's just make it always on. We don't target any power constrained usecases and this regulator is required for USB to function correctly. Fixes: 3f72e2d ("arm64: dts: qcom: Add Dragonboard 845c") Suggested-by: Bjorn Andersson <quic_bjorande@quicinc.com> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Link: https://lore.kernel.org/r/20240320122515.3243711-1-caleb.connolly@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 17a188d commit d73ed58

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

arch/arm64/boot/dts/qcom/sdm845-db845c.dts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,12 @@
195195

196196
gpio = <&tlmm 90 GPIO_ACTIVE_HIGH>;
197197
enable-active-high;
198+
/*
199+
* FIXME: this regulator is responsible for VBUS on the left USB
200+
* port. Keep it always on until we can correctly model this
201+
* relationship.
202+
*/
203+
regulator-always-on;
198204

199205
pinctrl-names = "default";
200206
pinctrl-0 = <&pcie0_pwren_state>;

0 commit comments

Comments
 (0)