Skip to content

Commit d76653c

Browse files
nathanchancebbrezillon
authored andcommitted
drm/panthor: Fix clang -Wunused-but-set-variable in tick_ctx_apply()
Clang warns (or errors with CONFIG_WERROR): drivers/gpu/drm/panthor/panthor_sched.c:2048:6: error: variable 'csg_mod_mask' set but not used [-Werror,-Wunused-but-set-variable] 2048 | u32 csg_mod_mask = 0, free_csg_slots = 0; | ^ 1 error generated. The variable is an artifact left over from refactoring that occurred during the development of the initial series for this driver. Remove it to resolve the warning. Fixes: de85488 ("drm/panthor: Add the scheduler logical block") Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Steven Price <steven.price@arm.com> Reviewed-by: Justin Stitt <justinstitt@google.com> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240328-panthor-drop-csg_mod_mask-v1-1-5a80be3df581@kernel.org
1 parent 962f88b commit d76653c

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/gpu/drm/panthor/panthor_sched.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2045,7 +2045,7 @@ tick_ctx_apply(struct panthor_scheduler *sched, struct panthor_sched_tick_ctx *c
20452045
struct panthor_device *ptdev = sched->ptdev;
20462046
struct panthor_csg_slot *csg_slot;
20472047
int prio, new_csg_prio = MAX_CSG_PRIO, i;
2048-
u32 csg_mod_mask = 0, free_csg_slots = 0;
2048+
u32 free_csg_slots = 0;
20492049
struct panthor_csg_slots_upd_ctx upd_ctx;
20502050
int ret;
20512051

@@ -2139,7 +2139,6 @@ tick_ctx_apply(struct panthor_scheduler *sched, struct panthor_sched_tick_ctx *c
21392139

21402140
csg_iface = panthor_fw_get_csg_iface(ptdev, csg_id);
21412141
csg_slot = &sched->csg_slots[csg_id];
2142-
csg_mod_mask |= BIT(csg_id);
21432142
group_bind_locked(group, csg_id);
21442143
csg_slot_prog_locked(ptdev, csg_id, new_csg_prio--);
21452144
csgs_upd_ctx_queue_reqs(ptdev, &upd_ctx, csg_id,

0 commit comments

Comments
 (0)