net: bgmac: Fix an erroneous kfree() in bgmac_remove()

tititiou36 · kuba-moo · commit d7dd6eccfbc9 · 2022-06-14T19:16:36.000-07:00
'bgmac' is part of a managed resource allocated with bgmac_alloc(). It should not be freed explicitly. Remove the erroneous kfree() from the .remove() function. Fixes: 34a5102 ("net: bgmac: allocate struct bgmac just once & don't copy it") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Link: https://lore.kernel.org/r/a026153108dd21239036a032b95c25b5cece253b.1655153616.git.christophe.jaillet@wanadoo.fr Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
@@ -332,7 +332,6 @@ static void bgmac_remove(struct bcma_device *core)
 	bcma_mdio_mii_unregister(bgmac->mii_bus);
 	bgmac_enet_remove(bgmac);
 	bcma_set_drvdata(core, NULL);
-	kfree(bgmac);
 }
 
 static struct bcma_driver bgmac_bcma_driver = {

Original file line number	Diff line number	Diff line change
`@@ -332,7 +332,6 @@ static void bgmac_remove(struct bcma_device *core)`
`332`	`332`	`bcma_mdio_mii_unregister(bgmac->mii_bus);`
`333`	`333`	`bgmac_enet_remove(bgmac);`
`334`	`334`	`bcma_set_drvdata(core, NULL);`
`335`		`- kfree(bgmac);`
`336`	`335`	`}`
`337`	`336`
`338`	`337`	`static struct bcma_driver bgmac_bcma_driver = {`