Skip to content

Commit d8300e6

Browse files
masneybandersson
authored andcommitted
clk: qcom: regmap-divider: convert from divider_round_rate() to divider_determine_rate()
The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate = divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: b6f9051 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()") Signed-off-by: Brian Masney <bmasney@redhat.com> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/r/20260108-clk-divider-round-rate-v1-16-535a3ed73bf3@redhat.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 349f02c commit d8300e6

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

drivers/clk/qcom/clk-regmap-divider.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,8 @@ static int div_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
3434
{
3535
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
3636

37-
req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
38-
NULL,
39-
divider->width,
40-
CLK_DIVIDER_ROUND_CLOSEST);
41-
42-
return 0;
37+
return divider_determine_rate(hw, req, NULL, divider->width,
38+
CLK_DIVIDER_ROUND_CLOSEST);
4339
}
4440

4541
static int div_set_rate(struct clk_hw *hw, unsigned long rate,

0 commit comments

Comments
 (0)