Skip to content

Commit d860974

Browse files
YeongjinGilJaegeuk Kim
authored andcommitted
f2fs: optimize f2fs_overwrite_io() for f2fs_iomap_begin
When overwriting already allocated blocks, f2fs_iomap_begin() calls f2fs_overwrite_io() to check block mappings. However, f2fs_overwrite_io() iterates through all mapped blocks in the range, which can be inefficient for fragmented files with large I/O requests. This patch optimizes f2fs_overwrite_io() by adding a 'check_first' parameter and introducing __f2fs_overwrite_io() helper. When called from f2fs_iomap_begin(), we only check the first mapping to determine if the range is already allocated, which is sufficient for setting map.m_may_create. This optimization significantly reduces the number of f2fs_map_blocks() calls in f2fs_overwrite_io() when called from f2fs_iomap_begin(), especially for fragmented files with large I/O requests. Cc: stable@kernel.org Fixes: 351bc76 ("f2fs: optimize f2fs DIO overwrites") Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com> Reviewed-by: Sunmin Jeong <s_min.jeong@samsung.com> Signed-off-by: Yeongjin Gil <youngjin.gil@samsung.com> Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 91b76f1 commit d860974

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

fs/f2fs/data.c

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1865,7 +1865,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag)
18651865
return err;
18661866
}
18671867

1868-
bool f2fs_overwrite_io(struct inode *inode, loff_t pos, size_t len)
1868+
static bool __f2fs_overwrite_io(struct inode *inode, loff_t pos, size_t len,
1869+
bool check_first)
18691870
{
18701871
struct f2fs_map_blocks map;
18711872
block_t last_lblk;
@@ -1887,10 +1888,17 @@ bool f2fs_overwrite_io(struct inode *inode, loff_t pos, size_t len)
18871888
if (err || map.m_len == 0)
18881889
return false;
18891890
map.m_lblk += map.m_len;
1891+
if (check_first)
1892+
break;
18901893
}
18911894
return true;
18921895
}
18931896

1897+
bool f2fs_overwrite_io(struct inode *inode, loff_t pos, size_t len)
1898+
{
1899+
return __f2fs_overwrite_io(inode, pos, len, false);
1900+
}
1901+
18941902
static int f2fs_xattr_fiemap(struct inode *inode,
18951903
struct fiemap_extent_info *fieinfo)
18961904
{
@@ -4487,7 +4495,7 @@ static int f2fs_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
44874495
* f2fs_map_lock and f2fs_balance_fs are not necessary.
44884496
*/
44894497
if ((flags & IOMAP_WRITE) &&
4490-
!f2fs_overwrite_io(inode, offset, length))
4498+
!__f2fs_overwrite_io(inode, offset, length, true))
44914499
map.m_may_create = true;
44924500

44934501
err = f2fs_map_blocks(inode, &map, F2FS_GET_BLOCK_DIO);

0 commit comments

Comments
 (0)