Skip to content

Commit d88e2a2

Browse files
committed
mm, pagemap: remove SLOB and SLQB from comments and documentation
SLOB has been removed and SLQB never merged, so remove their mentions from comments and documentation of pagemap. In stable_page_flags() also correct an outdated comment mentioning that PageBuddy() means a page->_refcount of -1, and remove compound_head() from the PageSlab() call, as that's already implicitly there thanks to PF_NO_TAIL. Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: Lorenzo Stoakes <lstoakes@gmail.com> Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
1 parent c4ba69f commit d88e2a2

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

Documentation/admin-guide/mm/pagemap.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ Short descriptions to the page flags
9191
The page is being locked for exclusive access, e.g. by undergoing read/write
9292
IO.
9393
7 - SLAB
94-
The page is managed by the SLAB/SLOB/SLUB/SLQB kernel memory allocator.
95-
When compound page is used, SLUB/SLQB will only set this flag on the head
96-
page; SLOB will not flag it at all.
94+
The page is managed by the SLAB/SLUB kernel memory allocator.
95+
When compound page is used, either will only set this flag on the head
96+
page.
9797
10 - BUDDY
9898
A free memory block managed by the buddy system allocator.
9999
The buddy system organizes free memory in blocks of various orders.

fs/proc/page.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ u64 stable_page_flags(struct page *page)
125125
/*
126126
* pseudo flags for the well known (anonymous) memory mapped pages
127127
*
128-
* Note that page->_mapcount is overloaded in SLOB/SLUB/SLQB, so the
128+
* Note that page->_mapcount is overloaded in SLAB, so the
129129
* simple test in page_mapped() is not enough.
130130
*/
131131
if (!PageSlab(page) && page_mapped(page))
@@ -165,9 +165,8 @@ u64 stable_page_flags(struct page *page)
165165

166166

167167
/*
168-
* Caveats on high order pages: page->_refcount will only be set
169-
* -1 on the head page; SLUB/SLQB do the same for PG_slab;
170-
* SLOB won't set PG_slab at all on compound pages.
168+
* Caveats on high order pages: PG_buddy and PG_slab will only be set
169+
* on the head page.
171170
*/
172171
if (PageBuddy(page))
173172
u |= 1 << KPF_BUDDY;
@@ -185,7 +184,7 @@ u64 stable_page_flags(struct page *page)
185184
u |= kpf_copy_bit(k, KPF_LOCKED, PG_locked);
186185

187186
u |= kpf_copy_bit(k, KPF_SLAB, PG_slab);
188-
if (PageTail(page) && PageSlab(compound_head(page)))
187+
if (PageTail(page) && PageSlab(page))
189188
u |= 1 << KPF_SLAB;
190189

191190
u |= kpf_copy_bit(k, KPF_ERROR, PG_error);

0 commit comments

Comments
 (0)