Skip to content

Commit d89aad9

Browse files
DmtKatsbroonie
authored andcommitted
ASoC: tlv320adcx140: Propagate error codes during probe
When scanning for the reset pin, we could get an -EPROBE_DEFER. The driver would assume that no reset pin had been defined, which would mean that the chip would never be powered. Now we both respect any error we get from devm_gpiod_get_optional. We also now properly report the missing GPIO definition when 'gpio_reset' is NULL. Signed-off-by: Dimitrios Katsaros <patcherwork@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Link: https://patch.msgid.link/20260113-sound-soc-codecs-tvl320adcx140-v4-3-8f7ecec525c8@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent be7664c commit d89aad9

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

sound/soc/codecs/tlv320adcx140.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1154,6 +1154,9 @@ static int adcx140_i2c_probe(struct i2c_client *i2c)
11541154
adcx140->gpio_reset = devm_gpiod_get_optional(adcx140->dev,
11551155
"reset", GPIOD_OUT_LOW);
11561156
if (IS_ERR(adcx140->gpio_reset))
1157+
return dev_err_probe(&i2c->dev, PTR_ERR(adcx140->gpio_reset),
1158+
"Failed to get Reset GPIO\n");
1159+
if (!adcx140->gpio_reset)
11571160
dev_info(&i2c->dev, "Reset GPIO not defined\n");
11581161

11591162
adcx140->supply_areg = devm_regulator_get_optional(adcx140->dev,

0 commit comments

Comments
 (0)