Skip to content

Commit d8adf5b

Browse files
tq-schiffernrobherring
authored andcommitted
scripts/dtc: dtx_diff: remove broken example from help text
dtx_diff suggests to use <(...) syntax to pipe two inputs into it, but this has never worked: The /proc/self/fds/... paths passed by the shell will fail the `[ -f "${dtx}" ] && [ -r "${dtx}" ]` check in compile_to_dts, but even with this check removed, the function cannot work: hexdump will eat up the DTB magic, making the subsequent dtc call fail, as a pipe cannot be rewound. Simply remove this broken example, as there is already an alternative one that works fine. Fixes: 10eadc2 ("dtc: create tool to diff device trees") Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Reviewed-by: Frank Rowand <frank.rowand@sony.com> Signed-off-by: Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20220113081918.10387-1-matthias.schiffer@ew.tq-group.com
1 parent af35a8b commit d8adf5b

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

scripts/dtc/dtx_diff

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,8 @@ Otherwise DTx is treated as a dts source file (aka .dts).
5959
or '/include/' to be processed.
6060
6161
If DTx_1 and DTx_2 are in different architectures, then this script
62-
may not work since \${ARCH} is part of the include path. Two possible
63-
workarounds:
64-
65-
`basename $0` \\
66-
<(ARCH=arch_of_dtx_1 `basename $0` DTx_1) \\
67-
<(ARCH=arch_of_dtx_2 `basename $0` DTx_2)
62+
may not work since \${ARCH} is part of the include path. The following
63+
workaround can be used:
6864
6965
`basename $0` ARCH=arch_of_dtx_1 DTx_1 >tmp_dtx_1.dts
7066
`basename $0` ARCH=arch_of_dtx_2 DTx_2 >tmp_dtx_2.dts

0 commit comments

Comments
 (0)