Skip to content

Commit d94bc2b

Browse files
andredalexandrebelloni
authored andcommitted
rtc: sd2405al: drop needless struct sd2405al::rtc member
The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Tested-by: Tóth János <gomba007@gmail.com> Signed-off-by: André Draszik <andre.draszik@linaro.org> Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-13-d4689a71668c@linaro.org Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent cd2a705 commit d94bc2b

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

drivers/rtc/rtc-sd2405al.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242

4343
struct sd2405al {
4444
struct device *dev;
45-
struct rtc_device *rtc;
4645
struct regmap *regmap;
4746
};
4847

@@ -167,6 +166,7 @@ static const struct regmap_config sd2405al_regmap_conf = {
167166
static int sd2405al_probe(struct i2c_client *client)
168167
{
169168
struct sd2405al *sd2405al;
169+
struct rtc_device *rtc;
170170
int ret;
171171

172172
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
@@ -182,17 +182,17 @@ static int sd2405al_probe(struct i2c_client *client)
182182
if (IS_ERR(sd2405al->regmap))
183183
return PTR_ERR(sd2405al->regmap);
184184

185-
sd2405al->rtc = devm_rtc_allocate_device(&client->dev);
186-
if (IS_ERR(sd2405al->rtc))
187-
return PTR_ERR(sd2405al->rtc);
185+
rtc = devm_rtc_allocate_device(&client->dev);
186+
if (IS_ERR(rtc))
187+
return PTR_ERR(rtc);
188188

189-
sd2405al->rtc->ops = &sd2405al_rtc_ops;
190-
sd2405al->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
191-
sd2405al->rtc->range_max = RTC_TIMESTAMP_END_2099;
189+
rtc->ops = &sd2405al_rtc_ops;
190+
rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
191+
rtc->range_max = RTC_TIMESTAMP_END_2099;
192192

193193
dev_set_drvdata(&client->dev, sd2405al);
194194

195-
ret = devm_rtc_register_device(sd2405al->rtc);
195+
ret = devm_rtc_register_device(rtc);
196196
if (ret < 0)
197197
return ret;
198198

0 commit comments

Comments
 (0)