Skip to content

Commit d95e99a

Browse files
arndbjgunthorpe
authored andcommitted
RDMA/irdma: Fix irdma_alloc_ucontext_resp padding
A recent commit modified struct irdma_alloc_ucontext_resp by adding a member with implicit padding in front of it, though this does not change the offset of the data members other than m68k. Reported by scripts/check-uapi.sh: ==== ABI differences detected in include/rdma/irdma-abi.h from 1dd7bde2e91c -> HEAD ==== [C] 'struct irdma_alloc_ucontext_resp' changed: type size changed from 704 to 640 (in bits) 1 data member deletion: '__u8 rsvd3[2]', at offset 640 (in bits) at irdma-abi.h:61:1 1 data member insertion: '__u8 revd3[2]', at offset 592 (in bits) at irdma-abi.h:60:1 Change the size back to the previous version, and remove the implicit padding by making it explicit and matching what x86-64 would do by placing max_hw_srq_quanta member into a naturally aligned location. Fixes: 563e1fe ("RDMA/irdma: Add SRQ support") Link: https://patch.msgid.link/r/20251208133849.315451-1-arnd@kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Tested-by: Jacob Moroni <jmoroni@google.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
1 parent 2dc675f commit d95e99a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

include/uapi/rdma/irdma-abi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ struct irdma_alloc_ucontext_resp {
5757
__u8 rsvd2;
5858
__aligned_u64 comp_mask;
5959
__u16 min_hw_wq_size;
60+
__u8 revd3[2];
6061
__u32 max_hw_srq_quanta;
61-
__u8 rsvd3[2];
6262
};
6363

6464
struct irdma_alloc_pd_resp {

0 commit comments

Comments
 (0)