Skip to content

Commit d9c454a

Browse files
Chao LiuJaegeuk Kim
authored andcommitted
f2fs: make f2fs_read_inline_data() more readable
In f2fs_read_inline_data(), it is confused with checking of inline_data flag, as we checked it before calling. So this patch add some comments for f2fs_has_inline_data(). Signed-off-by: Chao Liu <liuchao@coolpad.com> Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 677a82b commit d9c454a

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

fs/f2fs/f2fs.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3167,6 +3167,10 @@ static inline int inline_xattr_size(struct inode *inode)
31673167
return 0;
31683168
}
31693169

3170+
/*
3171+
* Notice: check inline_data flag without inode page lock is unsafe.
3172+
* It could change at any time by f2fs_convert_inline_page().
3173+
*/
31703174
static inline int f2fs_has_inline_data(struct inode *inode)
31713175
{
31723176
return is_inode_flag_set(inode, FI_INLINE_DATA);

0 commit comments

Comments
 (0)