Skip to content

Commit da0ba0c

Browse files
mudongliangjwrdegoede
authored andcommitted
platform/x86/intel: vsec: Fix a memory leak in intel_vsec_add_aux
The first error handling code in intel_vsec_add_aux misses the deallocation of intel_vsec_dev->resource. Fix this by adding kfree(intel_vsec_dev->resource) in the error handling code. Reviewed-by: David E. Box <david.e.box@linux.intel.com> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn> Link: https://lore.kernel.org/r/20230309040107.534716-4-dzm91@hust.edu.cn Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 1a0009a commit da0ba0c

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • drivers/platform/x86/intel

drivers/platform/x86/intel/vsec.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
154154
ret = ida_alloc(intel_vsec_dev->ida, GFP_KERNEL);
155155
mutex_unlock(&vsec_ida_lock);
156156
if (ret < 0) {
157+
kfree(intel_vsec_dev->resource);
157158
kfree(intel_vsec_dev);
158159
return ret;
159160
}

0 commit comments

Comments
 (0)