Skip to content

Commit da30a34

Browse files
andy-shevrafaeljw
authored andcommitted
ACPI: SPCR: Prefix error messages with FW_BUG
The table values that are not defined in the specification are considered non-fatal errors in the code. However, they are firmware bugs, so point this out in the messages by prefixing them with FW_BUG. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 91d7b60 commit da30a34

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/acpi/spcr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,12 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
110110
u32 bit_width = table->serial_port.access_width;
111111

112112
if (bit_width > ACPI_ACCESS_BIT_MAX) {
113-
pr_err("Unacceptable wide SPCR Access Width. Defaulting to byte size\n");
113+
pr_err(FW_BUG "Unacceptable wide SPCR Access Width. Defaulting to byte size\n");
114114
bit_width = ACPI_ACCESS_BIT_DEFAULT;
115115
}
116116
switch (ACPI_ACCESS_BIT_WIDTH((bit_width))) {
117117
default:
118-
pr_err("Unexpected SPCR Access Width. Defaulting to byte size\n");
118+
pr_err(FW_BUG "Unexpected SPCR Access Width. Defaulting to byte size\n");
119119
fallthrough;
120120
case 8:
121121
iotype = "mmio";

0 commit comments

Comments
 (0)