gpio: mpc8xxx: Fix wakeup source leaks on device unbind

krzk · Bartosz Golaszewski · commit da47605e43af · 2025-04-08T10:56:25.000+02:00
Device can be unbound, so driver must also release memory for the wakeup source. Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20250406202245.53854-1-krzysztof.kozlowski@linaro.org Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
@@ -410,7 +410,9 @@ static int mpc8xxx_probe(struct platform_device *pdev)
 		goto err;
 	}
 
-	device_init_wakeup(dev, true);
+	ret = devm_device_init_wakeup(dev);
+	if (ret)
+		return dev_err_probe(dev, ret, "Failed to init wakeup\n");
 
 	return 0;
 err:

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,9 @@ static int mpc8xxx_probe(struct platform_device *pdev)`
`410`	`410`	`goto err;`
`411`	`411`	`}`
`412`	`412`
`413`		`- device_init_wakeup(dev, true);`
	`413`	`+ ret = devm_device_init_wakeup(dev);`
	`414`	`+ if (ret)`
	`415`	`+ return dev_err_probe(dev, ret, "Failed to init wakeup\n");`
`414`	`416`
`415`	`417`	`return 0;`
`416`	`418`	`err:`