Skip to content

Commit da7e48d

Browse files
mwalleambarus
authored andcommitted
mtd: spi-nor: remove or move flash_info comments
Most of the comments are a relict of the past when the flash_info was just one table. Most of them are useless. Remove them. Signed-off-by: Michael Walle <mwalle@kernel.org> Link: https://lore.kernel.org/r/20230807-mtd-flash-info-db-rework-v3-16-e60548861b10@kernel.org Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
1 parent 3e85be9 commit da7e48d

11 files changed

Lines changed: 1 addition & 14 deletions

File tree

drivers/mtd/spi-nor/atmel.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ static const struct spi_nor_fixups atmel_nor_global_protection_fixups = {
163163
};
164164

165165
static const struct flash_info atmel_nor_parts[] = {
166-
/* Atmel -- some are (confusingly) marketed as "DataFlash" */
167166
{ "at25fs010", INFO(0x1f6601, 0, 32 * 1024, 4)
168167
FLAGS(SPI_NOR_HAS_LOCK)
169168
NO_SFDP_FLAGS(SECT_4K)

drivers/mtd/spi-nor/eon.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "core.h"
1010

1111
static const struct flash_info eon_nor_parts[] = {
12-
/* EON -- en25xxx */
1312
{ "en25f32", INFO(0x1c3116, 0, 64 * 1024, 64)
1413
NO_SFDP_FLAGS(SECT_4K) },
1514
{ "en25p32", INFO(0x1c2016, 0, 64 * 1024, 64) },

drivers/mtd/spi-nor/esmt.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "core.h"
1010

1111
static const struct flash_info esmt_nor_parts[] = {
12-
/* ESMT */
1312
{ "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64)
1413
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
1514
NO_SFDP_FLAGS(SECT_4K) },

drivers/mtd/spi-nor/everspin.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "core.h"
1010

1111
static const struct flash_info everspin_nor_parts[] = {
12-
/* Everspin */
1312
{ "mr25h128", CAT25_INFO(16 * 1024, 1, 256, 2) },
1413
{ "mr25h256", CAT25_INFO(32 * 1024, 1, 256, 2) },
1514
{ "mr25h10", CAT25_INFO(128 * 1024, 1, 256, 3) },

drivers/mtd/spi-nor/intel.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "core.h"
1010

1111
static const struct flash_info intel_nor_parts[] = {
12-
/* Intel/Numonyx -- xxxs33b */
1312
{ "160s33b", INFO(0x898911, 0, 64 * 1024, 32)
1413
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
1514
{ "320s33b", INFO(0x898912, 0, 64 * 1024, 64)

drivers/mtd/spi-nor/issi.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ static const struct spi_nor_fixups pm25lv_nor_fixups = {
4747
};
4848

4949
static const struct flash_info issi_nor_parts[] = {
50-
/* ISSI */
5150
{ "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2)
5251
NO_SFDP_FLAGS(SECT_4K) },
5352
{ "is25lq040b", INFO(0x9d4013, 0, 64 * 1024, 8)
@@ -76,7 +75,6 @@ static const struct flash_info issi_nor_parts[] = {
7675
FLAGS(SPI_NOR_QUAD_PP)
7776
.fixups = &is25lp256_fixups },
7877

79-
/* PMC */
8078
{ "pm25lv512", INFO0(32 * 1024, 2)
8179
NO_SFDP_FLAGS(SECT_4K)
8280
.fixups = &pm25lv_nor_fixups

drivers/mtd/spi-nor/macronix.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ static const struct spi_nor_fixups mx25l25635_fixups = {
3333
};
3434

3535
static const struct flash_info macronix_nor_parts[] = {
36-
/* Macronix */
3736
{ "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1)
3837
NO_SFDP_FLAGS(SECT_4K) },
3938
{ "mx25l2005a", INFO(0xc22012, 0, 64 * 1024, 4)

drivers/mtd/spi-nor/spansion.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -756,9 +756,6 @@ static const struct spi_nor_fixups s25fs_s_nor_fixups = {
756756
};
757757

758758
static const struct flash_info spansion_nor_parts[] = {
759-
/* Spansion/Cypress -- single (large) sector size only, at least
760-
* for the chips listed here (without boot sectors).
761-
*/
762759
{ "s25sl032p", INFO(0x010215, 0x4d00, 64 * 1024, 64)
763760
NO_SFDP_FLAGS(SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
764761
{ "s25sl064p", INFO(0x010216, 0x4d00, 64 * 1024, 128)

drivers/mtd/spi-nor/sst.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ static const struct spi_nor_fixups sst26vf_nor_fixups = {
6161
};
6262

6363
static const struct flash_info sst_nor_parts[] = {
64-
/* SST -- large erase sizes are "overlays", "sectors" are 4K */
6564
{ "sst25vf040b", INFO(0xbf258d, 0, 64 * 1024, 8)
6665
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
6766
NO_SFDP_FLAGS(SECT_4K)

drivers/mtd/spi-nor/winbond.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ static const struct spi_nor_fixups w25q256_fixups = {
4242
};
4343

4444
static const struct flash_info winbond_nor_parts[] = {
45-
/* Winbond -- w25x "blocks" are 64K, "sectors" are 4KiB */
4645
{ "w25x05", INFO(0xef3010, 0, 64 * 1024, 1)
4746
NO_SFDP_FLAGS(SECT_4K) },
4847
{ "w25x10", INFO(0xef3011, 0, 64 * 1024, 2)

0 commit comments

Comments
 (0)