Skip to content

Commit dad1730

Browse files
ossilatortiwai
authored andcommitted
ALSA: emu10k1: don't stop DSP in _snd_emu10k1_{,audigy_}init_efx()
These functions don't actually touch the DSP until they poke the code into it, at which point it's temporarily stopped anyway. And fx8010.dbg is already zero anyway. Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Link: https://lore.kernel.org/r/20230422161021.1144004-2-oswald.buddenhagen@gmx.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 3750528 commit dad1730

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

sound/pci/emu10k1/emufx.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1259,9 +1259,6 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu)
12591259
gpr_map[gpr++] = 0x0000ffff;
12601260
bit_shifter16 = gpr;
12611261

1262-
/* stop FX processor */
1263-
snd_emu10k1_ptr_write(emu, A_DBG, 0, (emu->fx8010.dbg = 0) | A_DBG_SINGLE_STEP);
1264-
12651262
#if 1
12661263
/* PCM front Playback Volume (independent from stereo mix)
12671264
* playback = 0 + ( gpr * FXBUS_PCM_LEFT_FRONT >> 31)
@@ -1903,9 +1900,6 @@ static int _snd_emu10k1_init_efx(struct snd_emu10k1 *emu)
19031900
tmp = 0x88; /* we need 4 temporary GPR */
19041901
/* from 0x8c to 0xff is the area for tone control */
19051902

1906-
/* stop FX processor */
1907-
snd_emu10k1_ptr_write(emu, DBG, 0, (emu->fx8010.dbg = 0) | EMU10K1_DBG_SINGLE_STEP);
1908-
19091903
/*
19101904
* Process FX Buses
19111905
*/

0 commit comments

Comments
 (0)