bcachefs: Fix bch2_check_nlinks() for snapshots

Kent Overstreet · Kent Overstreet · commit db18ef1a02bc · 2023-11-14T23:44:44.000-05:00
When searching the link table for the matching inode, we were searching
for a specific - incorrect - snapshot ID as well, causing us to fail to
find the inode.

Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/fsck.c b/fs/bcachefs/fsck.c
@@ -2220,7 +2220,7 @@ static int nlink_cmp(const void *_l, const void *_r)
 	const struct nlink *l = _l;
 	const struct nlink *r = _r;
 
-	return cmp_int(l->inum, r->inum) ?: cmp_int(l->snapshot, r->snapshot);
+	return cmp_int(l->inum, r->inum);
 }
 
 static void inc_link(struct bch_fs *c, struct snapshots_seen *s,

Original file line number	Diff line number	Diff line change
`@@ -2220,7 +2220,7 @@ static int nlink_cmp(const void _l, const void _r)`
`2220`	`2220`	`const struct nlink *l = _l;`
`2221`	`2221`	`const struct nlink *r = _r;`
`2222`	`2222`
`2223`		`- return cmp_int(l->inum, r->inum) ?: cmp_int(l->snapshot, r->snapshot);`
	`2223`	`+ return cmp_int(l->inum, r->inum);`
`2224`	`2224`	`}`
`2225`	`2225`
`2226`	`2226`	`static void inc_link(struct bch_fs c, struct snapshots_seen s,`