Skip to content

Commit db1b4be

Browse files
everything411davem330
authored andcommitted
net: ethernet: mtk_wed: fix use-after-free panic in mtk_wed_setup_tc_block_cb()
When there are multiple ap interfaces on one band and with WED on, turning the interface down will cause a kernel panic on MT798X. Previously, cb_priv was freed in mtk_wed_setup_tc_block() without marking NULL,and mtk_wed_setup_tc_block_cb() didn't check the value, too. Assign NULL after free cb_priv in mtk_wed_setup_tc_block() and check NULL in mtk_wed_setup_tc_block_cb(). ---------- Unable to handle kernel paging request at virtual address 0072460bca32b4f5 Call trace: mtk_wed_setup_tc_block_cb+0x4/0x38 0xffffffc0794084bc tcf_block_playback_offloads+0x70/0x1e8 tcf_block_unbind+0x6c/0xc8 ... --------- Fixes: 7996844 ("net: ethernet: mtk_wed: introduce wed wo support") Signed-off-by: Zheng Zhang <everything411@qq.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 32316f6 commit db1b4be

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/net/ethernet/mediatek/mtk_wed.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2666,14 +2666,15 @@ mtk_wed_setup_tc_block_cb(enum tc_setup_type type, void *type_data, void *cb_pri
26662666
{
26672667
struct mtk_wed_flow_block_priv *priv = cb_priv;
26682668
struct flow_cls_offload *cls = type_data;
2669-
struct mtk_wed_hw *hw = priv->hw;
2669+
struct mtk_wed_hw *hw = NULL;
26702670

2671-
if (!tc_can_offload(priv->dev))
2671+
if (!priv || !tc_can_offload(priv->dev))
26722672
return -EOPNOTSUPP;
26732673

26742674
if (type != TC_SETUP_CLSFLOWER)
26752675
return -EOPNOTSUPP;
26762676

2677+
hw = priv->hw;
26772678
return mtk_flow_offload_cmd(hw->eth, cls, hw->index);
26782679
}
26792680

@@ -2729,6 +2730,7 @@ mtk_wed_setup_tc_block(struct mtk_wed_hw *hw, struct net_device *dev,
27292730
flow_block_cb_remove(block_cb, f);
27302731
list_del(&block_cb->driver_list);
27312732
kfree(block_cb->cb_priv);
2733+
block_cb->cb_priv = NULL;
27322734
}
27332735
return 0;
27342736
default:

0 commit comments

Comments
 (0)