udp: Use WARN_ON_ONCE() in udp_read_skb()

peilin-ye · kuba-moo · commit db39dfdc1c3b · 2022-09-22T06:42:57.000-07:00
Prevent udp_read_skb() from flooding the syslog. Suggested-by: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Peilin Ye <peilin.ye@bytedance.com> Link: https://lore.kernel.org/r/20220921005915.2697-1-yepeilin.cs@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
@@ -1821,7 +1821,7 @@ int udp_read_skb(struct sock *sk, skb_read_actor_t recv_actor)
 			continue;
 		}
 
-		WARN_ON(!skb_set_owner_sk_safe(skb, sk));
+		WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk));
 		used = recv_actor(sk, skb);
 		if (used <= 0) {
 			if (!copied)

Original file line number	Diff line number	Diff line change
`@@ -1821,7 +1821,7 @@ int udp_read_skb(struct sock *sk, skb_read_actor_t recv_actor)`
`1821`	`1821`	`continue;`
`1822`	`1822`	`}`
`1823`	`1823`
`1824`		`- WARN_ON(!skb_set_owner_sk_safe(skb, sk));`
	`1824`	`+ WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk));`
`1825`	`1825`	`used = recv_actor(sk, skb);`
`1826`	`1826`	`if (used <= 0) {`
`1827`	`1827`	`if (!copied)`