Skip to content

Commit db6fe4d

Browse files
committed
lib: Move KUnit tests into tests/ subdirectory
Following from the recent KUnit file naming discussion[1], move all KUnit tests in lib/ into lib/tests/. Link: https://lore.kernel.org/lkml/20240720165441.it.320-kees@kernel.org/ [1] Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> Acked-by: Jakub Kicinski <kuba@kernel.org> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Reviewed-by: David Gow <davidgow@google.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> Reviewed-by: Rae Moar <rmoar@google.com> Link: https://lore.kernel.org/r/20241202075545.3648096-4-davidgow@google.com Signed-off-by: Kees Cook <kees@kernel.org>
1 parent 84ec093 commit db6fe4d

29 files changed

Lines changed: 51 additions & 47 deletions

MAINTAINERS

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4017,10 +4017,10 @@ F: include/vdso/bits.h
40174017
F: lib/bitmap-str.c
40184018
F: lib/bitmap.c
40194019
F: lib/cpumask.c
4020-
F: lib/cpumask_kunit.c
40214020
F: lib/find_bit.c
40224021
F: lib/find_bit_benchmark.c
40234022
F: lib/test_bitmap.c
4023+
F: lib/tests/cpumask_kunit.c
40244024
F: tools/include/linux/bitfield.h
40254025
F: tools/include/linux/bitmap.h
40264026
F: tools/include/linux/bits.h
@@ -9065,9 +9065,10 @@ L: linux-hardening@vger.kernel.org
90659065
S: Supported
90669066
T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening
90679067
F: include/linux/fortify-string.h
9068-
F: lib/fortify_kunit.c
9069-
F: lib/memcpy_kunit.c
90709068
F: lib/test_fortify/*
9069+
F: lib/tests/fortify_kunit.c
9070+
F: lib/tests/memcpy_kunit.c
9071+
F: scripts/test_fortify.sh
90719072
K: \bunsafe_memcpy\b
90729073
K: \b__NO_FORTIFY\b
90739074

@@ -9755,9 +9756,9 @@ F: include/linux/string.h
97559756
F: include/linux/string_choices.h
97569757
F: include/linux/string_helpers.h
97579758
F: lib/string.c
9758-
F: lib/string_kunit.c
97599759
F: lib/string_helpers.c
9760-
F: lib/string_helpers_kunit.c
9760+
F: lib/tests/string_helpers_kunit.c
9761+
F: lib/tests/string_kunit.c
97619762
F: scripts/coccinelle/api/string_choices.cocci
97629763

97639764
GENERIC UIO DRIVER FOR PCI DEVICES
@@ -12985,7 +12986,7 @@ F: Documentation/trace/kprobes.rst
1298512986
F: include/asm-generic/kprobes.h
1298612987
F: include/linux/kprobes.h
1298712988
F: kernel/kprobes.c
12988-
F: lib/test_kprobes.c
12989+
F: lib/tests/test_kprobes.c
1298912990
F: samples/kprobes
1299012991

1299112992
KS0108 LCD CONTROLLER DRIVER
@@ -13315,7 +13316,7 @@ M: Mark Brown <broonie@kernel.org>
1331513316
R: Matti Vaittinen <mazziesaccount@gmail.com>
1331613317
F: include/linux/linear_range.h
1331713318
F: lib/linear_ranges.c
13318-
F: lib/test_linear_ranges.c
13319+
F: lib/tests/test_linear_ranges.c
1331913320

1332013321
LINUX FOR POWER MACINTOSH
1332113322
L: linuxppc-dev@lists.ozlabs.org
@@ -13443,7 +13444,7 @@ M: David Gow <davidgow@google.com>
1344313444
L: linux-kselftest@vger.kernel.org
1344413445
L: kunit-dev@googlegroups.com
1344513446
S: Maintained
13446-
F: lib/list-test.c
13447+
F: lib/tests/list-test.c
1344713448

1344813449
LITEX PLATFORM
1344913450
M: Karol Gugala <kgugala@antmicro.com>
@@ -21732,7 +21733,7 @@ M: Jason A. Donenfeld <Jason@zx2c4.com>
2173221733
S: Maintained
2173321734
F: include/linux/siphash.h
2173421735
F: lib/siphash.c
21735-
F: lib/siphash_kunit.c
21736+
F: lib/tests/siphash_kunit.c
2173621737

2173721738
SIS 190 ETHERNET DRIVER
2173821739
M: Francois Romieu <romieu@fr.zoreil.com>

lib/Makefile

Lines changed: 1 addition & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ obj-y += bcd.o sort.o parser.o debug_locks.o random32.o \
5252
percpu-refcount.o rhashtable.o base64.o \
5353
once.o refcount.o rcuref.o usercopy.o errseq.o bucket_locks.o \
5454
generic-radix-tree.o bitmap-str.o
55-
obj-$(CONFIG_STRING_KUNIT_TEST) += string_kunit.o
5655
obj-y += string_helpers.o
57-
obj-$(CONFIG_STRING_HELPERS_KUNIT_TEST) += string_helpers_kunit.o
5856
obj-y += hexdump.o
5957
obj-$(CONFIG_TEST_HEXDUMP) += test_hexdump.o
6058
obj-y += kstrtox.o
@@ -65,22 +63,17 @@ obj-$(CONFIG_TEST_DHRY) += test_dhry.o
6563
obj-$(CONFIG_TEST_FIRMWARE) += test_firmware.o
6664
obj-$(CONFIG_TEST_BITOPS) += test_bitops.o
6765
CFLAGS_test_bitops.o += -Werror
68-
obj-$(CONFIG_CPUMASK_KUNIT_TEST) += cpumask_kunit.o
6966
obj-$(CONFIG_TEST_SYSCTL) += test_sysctl.o
70-
obj-$(CONFIG_TEST_IOV_ITER) += kunit_iov_iter.o
71-
obj-$(CONFIG_HASH_KUNIT_TEST) += test_hash.o
7267
obj-$(CONFIG_TEST_IDA) += test_ida.o
7368
obj-$(CONFIG_TEST_UBSAN) += test_ubsan.o
7469
CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla)
7570
CFLAGS_test_ubsan.o += $(call cc-disable-warning, unused-but-set-variable)
7671
UBSAN_SANITIZE_test_ubsan.o := y
7772
obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
78-
obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
7973
obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
8074
obj-$(CONFIG_TEST_LKM) += test_module.o
8175
obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
8276
obj-$(CONFIG_TEST_RHASHTABLE) += test_rhashtable.o
83-
obj-$(CONFIG_TEST_SORT) += test_sort.o
8477
obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_keys.o
8578
obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o
8679
obj-$(CONFIG_TEST_DYNAMIC_DEBUG) += test_dynamic_debug.o
@@ -98,7 +91,6 @@ obj-$(CONFIG_TEST_XARRAY) += test_xarray.o
9891
obj-$(CONFIG_TEST_MAPLE_TREE) += test_maple_tree.o
9992
obj-$(CONFIG_TEST_PARMAN) += test_parman.o
10093
obj-$(CONFIG_TEST_KMOD) += test_kmod.o
101-
obj-$(CONFIG_TEST_RUNTIME) += tests/
10294
obj-$(CONFIG_TEST_DEBUG_VIRTUAL) += test_debug_virtual.o
10395
obj-$(CONFIG_TEST_MEMCAT_P) += test_memcat_p.o
10496
obj-$(CONFIG_TEST_OBJAGG) += test_objagg.o
@@ -107,10 +99,7 @@ obj-$(CONFIG_TEST_MEMINIT) += test_meminit.o
10799
obj-$(CONFIG_TEST_LOCKUP) += test_lockup.o
108100
obj-$(CONFIG_TEST_HMM) += test_hmm.o
109101
obj-$(CONFIG_TEST_FREE_PAGES) += test_free_pages.o
110-
obj-$(CONFIG_KPROBES_SANITY_TEST) += test_kprobes.o
111102
obj-$(CONFIG_TEST_REF_TRACKER) += test_ref_tracker.o
112-
CFLAGS_test_fprobe.o += $(CC_FLAGS_FTRACE)
113-
obj-$(CONFIG_FPROBE_SANITY_TEST) += test_fprobe.o
114103
obj-$(CONFIG_TEST_OBJPOOL) += test_objpool.o
115104

116105
obj-$(CONFIG_TEST_FPU) += test_fpu.o
@@ -132,7 +121,7 @@ endif
132121
obj-$(CONFIG_DEBUG_INFO_REDUCED) += debug_info.o
133122
CFLAGS_debug_info.o += $(call cc-option, -femit-struct-debug-detailed=any)
134123

135-
obj-y += math/ crypto/
124+
obj-y += math/ crypto/ tests/
136125

137126
obj-$(CONFIG_GENERIC_IOMAP) += iomap.o
138127
obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o
@@ -368,32 +357,6 @@ obj-$(CONFIG_OBJAGG) += objagg.o
368357
# pldmfw library
369358
obj-$(CONFIG_PLDMFW) += pldmfw/
370359

371-
# KUnit tests
372-
CFLAGS_bitfield_kunit.o := $(DISABLE_STRUCTLEAK_PLUGIN)
373-
obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
374-
obj-$(CONFIG_CHECKSUM_KUNIT) += checksum_kunit.o
375-
obj-$(CONFIG_UTIL_MACROS_KUNIT) += util_macros_kunit.o
376-
obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
377-
obj-$(CONFIG_HASHTABLE_KUNIT_TEST) += hashtable_test.o
378-
obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
379-
obj-$(CONFIG_BITS_TEST) += test_bits.o
380-
obj-$(CONFIG_CMDLINE_KUNIT_TEST) += cmdline_kunit.o
381-
obj-$(CONFIG_SLUB_KUNIT_TEST) += slub_kunit.o
382-
obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o
383-
obj-$(CONFIG_IS_SIGNED_TYPE_KUNIT_TEST) += is_signed_type_kunit.o
384-
CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare)
385-
obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o
386-
CFLAGS_stackinit_kunit.o += $(call cc-disable-warning, switch-unreachable)
387-
obj-$(CONFIG_STACKINIT_KUNIT_TEST) += stackinit_kunit.o
388-
CFLAGS_fortify_kunit.o += $(call cc-disable-warning, unsequenced)
389-
CFLAGS_fortify_kunit.o += $(call cc-disable-warning, stringop-overread)
390-
CFLAGS_fortify_kunit.o += $(call cc-disable-warning, stringop-truncation)
391-
CFLAGS_fortify_kunit.o += $(DISABLE_STRUCTLEAK_PLUGIN)
392-
obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
393-
obj-$(CONFIG_CRC_KUNIT_TEST) += crc_kunit.o
394-
obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
395-
obj-$(CONFIG_USERCOPY_KUNIT_TEST) += usercopy_kunit.o
396-
397360
obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o
398361

399362
obj-$(CONFIG_FIRMWARE_TABLE) += fw_table.o

lib/tests/Makefile

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,41 @@
1+
# SPDX-License-Identifier: GPL-2.0
2+
#
3+
# Makefile for tests of kernel library functions.
4+
5+
# KUnit tests
6+
CFLAGS_bitfield_kunit.o := $(DISABLE_STRUCTLEAK_PLUGIN)
7+
obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
8+
obj-$(CONFIG_BITS_TEST) += test_bits.o
9+
obj-$(CONFIG_CHECKSUM_KUNIT) += checksum_kunit.o
10+
obj-$(CONFIG_CMDLINE_KUNIT_TEST) += cmdline_kunit.o
11+
obj-$(CONFIG_CPUMASK_KUNIT_TEST) += cpumask_kunit.o
12+
obj-$(CONFIG_CRC_KUNIT_TEST) += crc_kunit.o
13+
CFLAGS_fortify_kunit.o += $(call cc-disable-warning, unsequenced)
14+
CFLAGS_fortify_kunit.o += $(call cc-disable-warning, stringop-overread)
15+
CFLAGS_fortify_kunit.o += $(call cc-disable-warning, stringop-truncation)
16+
CFLAGS_fortify_kunit.o += $(DISABLE_STRUCTLEAK_PLUGIN)
17+
obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
18+
CFLAGS_test_fprobe.o += $(CC_FLAGS_FTRACE)
19+
obj-$(CONFIG_FPROBE_SANITY_TEST) += test_fprobe.o
20+
obj-$(CONFIG_HASHTABLE_KUNIT_TEST) += hashtable_test.o
21+
obj-$(CONFIG_HASH_KUNIT_TEST) += test_hash.o
22+
obj-$(CONFIG_TEST_IOV_ITER) += kunit_iov_iter.o
23+
obj-$(CONFIG_IS_SIGNED_TYPE_KUNIT_TEST) += is_signed_type_kunit.o
24+
obj-$(CONFIG_KPROBES_SANITY_TEST) += test_kprobes.o
25+
obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
26+
obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
27+
obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
28+
obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o
29+
CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare)
30+
obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o
31+
obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
32+
obj-$(CONFIG_SLUB_KUNIT_TEST) += slub_kunit.o
33+
obj-$(CONFIG_TEST_SORT) += test_sort.o
34+
CFLAGS_stackinit_kunit.o += $(call cc-disable-warning, switch-unreachable)
35+
obj-$(CONFIG_STACKINIT_KUNIT_TEST) += stackinit_kunit.o
36+
obj-$(CONFIG_STRING_KUNIT_TEST) += string_kunit.o
37+
obj-$(CONFIG_STRING_HELPERS_KUNIT_TEST) += string_helpers_kunit.o
38+
obj-$(CONFIG_USERCOPY_KUNIT_TEST) += usercopy_kunit.o
39+
obj-$(CONFIG_UTIL_MACROS_KUNIT) += util_macros_kunit.o
40+
141
obj-$(CONFIG_TEST_RUNTIME_MODULE) += module/
File renamed without changes.

0 commit comments

Comments
 (0)