Skip to content

Commit dc155e1

Browse files
bulwahnmartinkpetersen
authored andcommitted
scsi: bsg: Drop needless assignment in scsi_bsg_sg_io_fn()
Commit ce70fd9 ("scsi: core: Remove the cmd field from struct scsi_request") refactored scsi_bsg_sg_io_fn() so that it does not allocate directly and hence does not return -ENOMEM in its error case. That makes a remaining assignment of -ENOMEM to the return variable needless. Drop this needless assignment in scsi_bsg_sg_io_fn(). No functional change. No change in resulting object code. Link: https://lore.kernel.org/r/20220315055325.14974-1-lukas.bulwahn@gmail.com Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent f45775b commit dc155e1

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/scsi/scsi_bsg.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ static int scsi_bsg_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr,
3131
return PTR_ERR(rq);
3232
rq->timeout = timeout;
3333

34-
ret = -ENOMEM;
3534
scmd = blk_mq_rq_to_pdu(rq);
3635
scmd->cmd_len = hdr->request_len;
3736
if (scmd->cmd_len > sizeof(scmd->cmnd)) {

0 commit comments

Comments
 (0)