Skip to content

Commit dc5aef6

Browse files
DispatchCodemichalsimek
authored andcommitted
soc/xilinx: replace use of system_unbound_wq with system_dfl_wq
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") system_dfl_wq should be the default workqueue so as not to enforce locality constraints for random work whenever it's not required. The old system_unbound_wq will be kept for a few release cycles. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Signed-off-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/20251104103942.96647-1-marco.crivellari@suse.com
1 parent 8f0b4cc commit dc5aef6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/soc/xilinx/zynqmp_power.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ static void subsystem_restart_event_callback(const u32 *payload, void *data)
8282
memcpy(zynqmp_pm_init_restart_work->args, &payload[0],
8383
sizeof(zynqmp_pm_init_restart_work->args));
8484

85-
queue_work(system_unbound_wq, &zynqmp_pm_init_restart_work->callback_work);
85+
queue_work(system_dfl_wq, &zynqmp_pm_init_restart_work->callback_work);
8686
}
8787

8888
static void suspend_event_callback(const u32 *payload, void *data)
@@ -95,7 +95,7 @@ static void suspend_event_callback(const u32 *payload, void *data)
9595
memcpy(zynqmp_pm_init_suspend_work->args, &payload[1],
9696
sizeof(zynqmp_pm_init_suspend_work->args));
9797

98-
queue_work(system_unbound_wq, &zynqmp_pm_init_suspend_work->callback_work);
98+
queue_work(system_dfl_wq, &zynqmp_pm_init_suspend_work->callback_work);
9999
}
100100

101101
static irqreturn_t zynqmp_pm_isr(int irq, void *data)
@@ -140,7 +140,7 @@ static void ipi_receive_callback(struct mbox_client *cl, void *data)
140140
memcpy(zynqmp_pm_init_suspend_work->args, &payload[1],
141141
sizeof(zynqmp_pm_init_suspend_work->args));
142142

143-
queue_work(system_unbound_wq,
143+
queue_work(system_dfl_wq,
144144
&zynqmp_pm_init_suspend_work->callback_work);
145145

146146
/* Send NULL message to mbox controller to ack the message */

0 commit comments

Comments
 (0)