Skip to content

Commit dc9786a

Browse files
committed
ALSA: us144mkii: Drop kernel-doc markers
We don't process this driver code for kernel-doc, and the "/**" marker leads to warnings with W=1 builds. Drop the superfluous markers, and also fix the invalid mark up, too. Link: https://patch.msgid.link/20260226155456.1092186-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 1d6452a commit dc9786a

5 files changed

Lines changed: 50 additions & 50 deletions

File tree

sound/usb/usx2y/us144mkii.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ MODULE_AUTHOR("Šerif Rami <ramiserifpersia@gmail.com>");
1010
MODULE_DESCRIPTION("ALSA Driver for TASCAM US-144MKII");
1111
MODULE_LICENSE("GPL");
1212

13-
/**
14-
* @brief Module parameters for ALSA card instantiation.
13+
/*
14+
* Module parameters for ALSA card instantiation.
1515
*
1616
* These parameters allow users to configure how the ALSA sound card
1717
* for the TASCAM US-144MKII is instantiated.
@@ -269,7 +269,7 @@ void tascam_stop_work_handler(struct work_struct *work)
269269
atomic_set(&tascam->active_urbs, 0);
270270
}
271271

272-
/**
272+
/*
273273
* tascam_card_private_free() - Frees private data associated with the sound
274274
* card.
275275
* @card: Pointer to the ALSA sound card instance.
@@ -291,7 +291,7 @@ static void tascam_card_private_free(struct snd_card *card)
291291
}
292292
}
293293

294-
/**
294+
/*
295295
* tascam_suspend() - Handles device suspension.
296296
* @intf: The USB interface being suspended.
297297
* @message: Power management message.
@@ -332,7 +332,7 @@ static int tascam_suspend(struct usb_interface *intf, pm_message_t message)
332332
return 0;
333333
}
334334

335-
/**
335+
/*
336336
* tascam_resume() - Handles device resumption from suspend.
337337
* @intf: The USB interface being resumed.
338338
*
@@ -390,7 +390,7 @@ static void tascam_error_timer(struct timer_list *t)
390390
schedule_work(&tascam->midi_out_work);
391391
}
392392

393-
/**
393+
/*
394394
* tascam_probe() - Probes for the TASCAM US-144MKII device.
395395
* @intf: The USB interface being probed.
396396
* @usb_id: The USB device ID.
@@ -565,7 +565,7 @@ static int tascam_probe(struct usb_interface *intf,
565565
return err;
566566
}
567567

568-
/**
568+
/*
569569
* tascam_disconnect() - Disconnects the TASCAM US-144MKII device.
570570
* @intf: The USB interface being disconnected.
571571
*

sound/usb/usx2y/us144mkii_capture.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
#include "us144mkii.h"
55

6-
/**
6+
/*
77
* tascam_capture_open() - Opens the PCM capture substream.
88
* @substream: The ALSA PCM substream to open.
99
*
@@ -23,7 +23,7 @@ static int tascam_capture_open(struct snd_pcm_substream *substream)
2323
return 0;
2424
}
2525

26-
/**
26+
/*
2727
* tascam_capture_close() - Closes the PCM capture substream.
2828
* @substream: The ALSA PCM substream to close.
2929
*
@@ -41,7 +41,7 @@ static int tascam_capture_close(struct snd_pcm_substream *substream)
4141
return 0;
4242
}
4343

44-
/**
44+
/*
4545
* tascam_capture_prepare() - Prepares the PCM capture substream for use.
4646
* @substream: The ALSA PCM substream to prepare.
4747
*
@@ -62,7 +62,7 @@ static int tascam_capture_prepare(struct snd_pcm_substream *substream)
6262
return 0;
6363
}
6464

65-
/**
65+
/*
6666
* tascam_capture_pointer() - Returns the current capture pointer position.
6767
* @substream: The ALSA PCM substream.
6868
*
@@ -91,7 +91,7 @@ tascam_capture_pointer(struct snd_pcm_substream *substream)
9191
return do_div(pos, runtime->buffer_size);
9292
}
9393

94-
/**
94+
/*
9595
* tascam_capture_ops - ALSA PCM operations for capture.
9696
*
9797
* This structure defines the callback functions for capture stream operations,
@@ -109,7 +109,7 @@ const struct snd_pcm_ops tascam_capture_ops = {
109109
.pointer = tascam_capture_pointer,
110110
};
111111

112-
/**
112+
/*
113113
* decode_tascam_capture_block() - Decodes a raw 512-byte block from the device.
114114
* @src_block: Pointer to the 512-byte raw source block.
115115
* @dst_block: Pointer to the destination buffer for decoded audio frames.

sound/usb/usx2y/us144mkii_controls.c

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,24 @@
33

44
#include "us144mkii.h"
55

6-
/**
7-
* @brief Text descriptions for playback output source options.
6+
/*
7+
* Text descriptions for playback output source options.
88
*
99
* Used by ALSA kcontrol elements to provide user-friendly names for
1010
* the playback routing options (e.g., "Playback 1-2", "Playback 3-4").
1111
*/
1212
static const char *const playback_source_texts[] = { "Playback 1-2",
1313
"Playback 3-4" };
1414

15-
/**
16-
* @brief Text descriptions for capture input source options.
15+
/*
16+
* Text descriptions for capture input source options.
1717
*
1818
* Used by ALSA kcontrol elements to provide user-friendly names for
1919
* the capture routing options (e.g., "Analog In", "Digital In").
2020
*/
2121
static const char *const capture_source_texts[] = { "Analog In", "Digital In" };
2222

23-
/**
23+
/*
2424
* tascam_playback_source_info() - ALSA control info callback for playback
2525
* source.
2626
* @kcontrol: The ALSA kcontrol instance.
@@ -38,7 +38,7 @@ static int tascam_playback_source_info(struct snd_kcontrol *kcontrol,
3838
return snd_ctl_enum_info(uinfo, 1, 2, playback_source_texts);
3939
}
4040

41-
/**
41+
/*
4242
* tascam_line_out_get() - ALSA control get callback for Line Outputs Source.
4343
* @kcontrol: The ALSA kcontrol instance.
4444
* @ucontrol: The ALSA control element value structure to fill.
@@ -60,7 +60,7 @@ static int tascam_line_out_get(struct snd_kcontrol *kcontrol,
6060
return 0;
6161
}
6262

63-
/**
63+
/*
6464
* tascam_line_out_put() - ALSA control put callback for Line Outputs Source.
6565
* @kcontrol: The ALSA kcontrol instance.
6666
* @ucontrol: The ALSA control element value structure containing the new value.
@@ -89,7 +89,7 @@ static int tascam_line_out_put(struct snd_kcontrol *kcontrol,
8989
return changed;
9090
}
9191

92-
/**
92+
/*
9393
* tascam_line_out_control - ALSA kcontrol definition for Line Outputs Source.
9494
*
9595
* This defines a new ALSA mixer control named "Line OUTPUTS Source" that allows
@@ -106,7 +106,7 @@ static const struct snd_kcontrol_new tascam_line_out_control = {
106106
.put = tascam_line_out_put,
107107
};
108108

109-
/**
109+
/*
110110
* tascam_digital_out_get() - ALSA control get callback for Digital Outputs
111111
* Source.
112112
* @kcontrol: The ALSA kcontrol instance.
@@ -129,7 +129,7 @@ static int tascam_digital_out_get(struct snd_kcontrol *kcontrol,
129129
return 0;
130130
}
131131

132-
/**
132+
/*
133133
* tascam_digital_out_put() - ALSA control put callback for Digital Outputs
134134
* Source.
135135
* @kcontrol: The ALSA kcontrol instance.
@@ -159,7 +159,7 @@ static int tascam_digital_out_put(struct snd_kcontrol *kcontrol,
159159
return changed;
160160
}
161161

162-
/**
162+
/*
163163
* tascam_digital_out_control - ALSA kcontrol definition for Digital Outputs
164164
* Source.
165165
*
@@ -177,7 +177,7 @@ static const struct snd_kcontrol_new tascam_digital_out_control = {
177177
.put = tascam_digital_out_put,
178178
};
179179

180-
/**
180+
/*
181181
* tascam_capture_source_info() - ALSA control info callback for capture source.
182182
* @kcontrol: The ALSA kcontrol instance.
183183
* @uinfo: The ALSA control element info structure to fill.
@@ -194,7 +194,7 @@ static int tascam_capture_source_info(struct snd_kcontrol *kcontrol,
194194
return snd_ctl_enum_info(uinfo, 1, 2, capture_source_texts);
195195
}
196196

197-
/**
197+
/*
198198
* tascam_capture_12_get() - ALSA control get callback for Capture channels 1
199199
* and 2 Source.
200200
* @kcontrol: The ALSA kcontrol instance.
@@ -217,7 +217,7 @@ static int tascam_capture_12_get(struct snd_kcontrol *kcontrol,
217217
return 0;
218218
}
219219

220-
/**
220+
/*
221221
* tascam_capture_12_put() - ALSA control put callback for Capture channels 1
222222
* and 2 Source.
223223
* @kcontrol: The ALSA kcontrol instance.
@@ -247,7 +247,7 @@ static int tascam_capture_12_put(struct snd_kcontrol *kcontrol,
247247
return changed;
248248
}
249249

250-
/**
250+
/*
251251
* tascam_capture_12_control - ALSA kcontrol definition for Capture channels 1
252252
* and 2 Source.
253253
*
@@ -265,7 +265,7 @@ static const struct snd_kcontrol_new tascam_capture_12_control = {
265265
.put = tascam_capture_12_put,
266266
};
267267

268-
/**
268+
/*
269269
* tascam_capture_34_get() - ALSA control get callback for Capture channels 3
270270
* and 4 Source.
271271
* @kcontrol: The ALSA kcontrol instance.
@@ -288,7 +288,7 @@ static int tascam_capture_34_get(struct snd_kcontrol *kcontrol,
288288
return 0;
289289
}
290290

291-
/**
291+
/*
292292
* tascam_capture_34_put() - ALSA control put callback for Capture channels 3
293293
* and 4 Source.
294294
* @kcontrol: The ALSA kcontrol instance.
@@ -318,7 +318,7 @@ static int tascam_capture_34_put(struct snd_kcontrol *kcontrol,
318318
return changed;
319319
}
320320

321-
/**
321+
/*
322322
* tascam_capture_34_control - ALSA kcontrol definition for Capture channels 3
323323
* and 4 Source.
324324
*
@@ -336,7 +336,7 @@ static const struct snd_kcontrol_new tascam_capture_34_control = {
336336
.put = tascam_capture_34_put,
337337
};
338338

339-
/**
339+
/*
340340
* tascam_samplerate_info() - ALSA control info callback for Sample Rate.
341341
* @kcontrol: The ALSA kcontrol instance.
342342
* @uinfo: The ALSA control element info structure to fill.
@@ -356,7 +356,7 @@ static int tascam_samplerate_info(struct snd_kcontrol *kcontrol,
356356
return 0;
357357
}
358358

359-
/**
359+
/*
360360
* tascam_samplerate_get() - ALSA control get callback for Sample Rate.
361361
* @kcontrol: The ALSA kcontrol instance.
362362
* @ucontrol: The ALSA control element value structure to fill.
@@ -400,7 +400,7 @@ static int tascam_samplerate_get(struct snd_kcontrol *kcontrol,
400400
return 0;
401401
}
402402

403-
/**
403+
/*
404404
* tascam_samplerate_control - ALSA kcontrol definition for Sample Rate.
405405
*
406406
* This defines a new ALSA mixer control named "Sample Rate" that displays

sound/usb/usx2y/us144mkii_midi.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
#include "us144mkii.h"
55

6-
/**
6+
/*
77
* tascam_midi_in_work_handler() - Deferred work for processing MIDI input.
88
* @work: The work_struct instance.
99
*
@@ -75,7 +75,7 @@ void tascam_midi_in_urb_complete(struct urb *urb)
7575
usb_put_urb(urb);
7676
}
7777

78-
/**
78+
/*
7979
* tascam_midi_in_open() - Opens the MIDI input substream.
8080
* @substream: The ALSA rawmidi substream to open.
8181
*
@@ -92,7 +92,7 @@ static int tascam_midi_in_open(struct snd_rawmidi_substream *substream)
9292
return 0;
9393
}
9494

95-
/**
95+
/*
9696
* tascam_midi_in_close() - Closes the MIDI input substream.
9797
* @substream: The ALSA rawmidi substream to close.
9898
*
@@ -103,7 +103,7 @@ static int tascam_midi_in_close(struct snd_rawmidi_substream *substream)
103103
return 0;
104104
}
105105

106-
/**
106+
/*
107107
* tascam_midi_in_trigger() - Triggers MIDI input stream activity.
108108
* @substream: The ALSA rawmidi substream.
109109
* @up: Boolean indicating whether to start (1) or stop (0) the stream.
@@ -150,7 +150,7 @@ static void tascam_midi_in_trigger(struct snd_rawmidi_substream *substream,
150150
}
151151
}
152152

153-
/**
153+
/*
154154
* tascam_midi_in_ops - ALSA rawmidi operations for MIDI input.
155155
*
156156
* This structure defines the callback functions for MIDI input stream
@@ -205,7 +205,7 @@ void tascam_midi_out_urb_complete(struct urb *urb)
205205
usb_put_urb(urb);
206206
}
207207

208-
/**
208+
/*
209209
* tascam_midi_out_work_handler() - Deferred work for sending MIDI data
210210
* @work: The work_struct instance.
211211
*
@@ -282,7 +282,7 @@ static void tascam_midi_out_work_handler(struct work_struct *work)
282282
}
283283
}
284284

285-
/**
285+
/*
286286
* tascam_midi_out_open() - Opens the MIDI output substream.
287287
* @substream: The ALSA rawmidi substream to open.
288288
*
@@ -301,7 +301,7 @@ static int tascam_midi_out_open(struct snd_rawmidi_substream *substream)
301301
return 0;
302302
}
303303

304-
/**
304+
/*
305305
* tascam_midi_out_close() - Closes the MIDI output substream.
306306
* @substream: The ALSA rawmidi substream to close.
307307
*
@@ -312,7 +312,7 @@ static int tascam_midi_out_close(struct snd_rawmidi_substream *substream)
312312
return 0;
313313
}
314314

315-
/**
315+
/*
316316
* tascam_midi_out_drain() - Drains the MIDI output stream.
317317
* @substream: The ALSA rawmidi substream.
318318
*
@@ -340,7 +340,7 @@ static void tascam_midi_out_drain(struct snd_rawmidi_substream *substream)
340340
usb_kill_anchored_urbs(&tascam->midi_out_anchor);
341341
}
342342

343-
/**
343+
/*
344344
* tascam_midi_out_trigger() - Triggers MIDI output stream activity.
345345
* @substream: The ALSA rawmidi substream.
346346
* @up: Boolean indicating whether to start (1) or stop (0) the stream.
@@ -361,7 +361,7 @@ static void tascam_midi_out_trigger(struct snd_rawmidi_substream *substream,
361361
}
362362
}
363363

364-
/**
364+
/*
365365
* tascam_midi_out_ops - ALSA rawmidi operations for MIDI output.
366366
*
367367
* This structure defines the callback functions for MIDI output stream

0 commit comments

Comments
 (0)