Skip to content

Commit dca5244

Browse files
willdeaconctmarinas
authored andcommitted
compiler.h: Raise minimum version of GCC to 5.1 for arm64
GCC versions >= 4.9 and < 5.1 have been shown to emit memory references beyond the stack pointer, resulting in memory corruption if an interrupt is taken after the stack pointer has been adjusted but before the reference has been executed. This leads to subtle, infrequent data corruption such as the EXT4 problems reported by Russell King at the link below. Life is too short for buggy compilers, so raise the minimum GCC version required by arm64 to 5.1. Reported-by: Russell King <linux@armlinux.org.uk> Suggested-by: Arnd Bergmann <arnd@kernel.org> Signed-off-by: Will Deacon <will@kernel.org> Tested-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: <stable@vger.kernel.org> Cc: Theodore Ts'o <tytso@mit.edu> Cc: Florian Weimer <fweimer@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Nick Desaulniers <ndesaulniers@google.com> Link: https://lore.kernel.org/r/20210105154726.GD1551@shell.armlinux.org.uk Link: https://lore.kernel.org/r/20210112224832.10980-1-will@kernel.org Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
1 parent c35a824 commit dca5244

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

include/linux/compiler-gcc.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@
1313
/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */
1414
#if GCC_VERSION < 40900
1515
# error Sorry, your version of GCC is too old - please use 4.9 or newer.
16+
#elif defined(CONFIG_ARM64) && GCC_VERSION < 50100
17+
/*
18+
* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293
19+
* https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk
20+
*/
21+
# error Sorry, your version of GCC is too old - please use 5.1 or newer.
1622
#endif
1723

1824
/*

0 commit comments

Comments
 (0)