Skip to content

Commit dcefa03

Browse files
Uwe Kleine-Königkrzk
authored andcommitted
memory: tegra186-emc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/8481c7e7d5b024325e6b1aabf7cb3a3707d211d6.1702822744.git.u.kleine-koenig@pengutronix.de Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
1 parent 1455b6b commit dcefa03

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/memory/tegra/tegra186-emc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ static int tegra186_emc_probe(struct platform_device *pdev)
378378
return err;
379379
}
380380

381-
static int tegra186_emc_remove(struct platform_device *pdev)
381+
static void tegra186_emc_remove(struct platform_device *pdev)
382382
{
383383
struct tegra_mc *mc = dev_get_drvdata(pdev->dev.parent);
384384
struct tegra186_emc *emc = platform_get_drvdata(pdev);
@@ -387,8 +387,6 @@ static int tegra186_emc_remove(struct platform_device *pdev)
387387

388388
mc->bpmp = NULL;
389389
tegra_bpmp_put(emc->bpmp);
390-
391-
return 0;
392390
}
393391

394392
static const struct of_device_id tegra186_emc_of_match[] = {
@@ -413,7 +411,7 @@ static struct platform_driver tegra186_emc_driver = {
413411
.sync_state = icc_sync_state,
414412
},
415413
.probe = tegra186_emc_probe,
416-
.remove = tegra186_emc_remove,
414+
.remove_new = tegra186_emc_remove,
417415
};
418416
module_platform_driver(tegra186_emc_driver);
419417

0 commit comments

Comments
 (0)