Skip to content

Commit dd24662

Browse files
Hersen Wualexdeucher
authored andcommitted
drm/amd/display: Return error code on DSC atomic check failure
[Why&How] We were not returning -EINVAL on DSC atomic check fail. Add it. Fixes: 71be4b1 ("drm/amd/display: dsc validate fail not pass to atomic check") Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent e0cce12 commit dd24662

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10170,6 +10170,7 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
1017010170
ret = compute_mst_dsc_configs_for_state(state, dm_state->context, vars);
1017110171
if (ret) {
1017210172
DRM_DEBUG_DRIVER("compute_mst_dsc_configs_for_state() failed\n");
10173+
ret = -EINVAL;
1017310174
goto fail;
1017410175
}
1017510176

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1410,6 +1410,7 @@ int pre_validate_dsc(struct drm_atomic_state *state,
14101410
ret = pre_compute_mst_dsc_configs_for_state(state, local_dc_state, vars);
14111411
if (ret != 0) {
14121412
DRM_INFO_ONCE("pre_compute_mst_dsc_configs_for_state() failed\n");
1413+
ret = -EINVAL;
14131414
goto clean_exit;
14141415
}
14151416

0 commit comments

Comments
 (0)