Skip to content

Commit dd462cf

Browse files
bijudasgeertu
authored andcommitted
pinctrl: renesas: rzg2l: Make reverse order of enable() for disable()
We usually do reverse order of enable() for disable(). Currently, the ordering of irq_chip_disable_parent() is not correct in rzg2l_gpio_irq_disable(). Fix the incorrect order. Fixes: db2e5f2 ("pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO interrupt") Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20230918123355.262115-2-biju.das.jz@bp.renesas.com Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
1 parent 84c580e commit dd462cf

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/pinctrl/renesas/pinctrl-rzg2l.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1175,6 +1175,8 @@ static void rzg2l_gpio_irq_disable(struct irq_data *d)
11751175
u32 port;
11761176
u8 bit;
11771177

1178+
irq_chip_disable_parent(d);
1179+
11781180
port = RZG2L_PIN_ID_TO_PORT(hwirq);
11791181
bit = RZG2L_PIN_ID_TO_PIN(hwirq);
11801182

@@ -1189,7 +1191,6 @@ static void rzg2l_gpio_irq_disable(struct irq_data *d)
11891191
spin_unlock_irqrestore(&pctrl->lock, flags);
11901192

11911193
gpiochip_disable_irq(gc, hwirq);
1192-
irq_chip_disable_parent(d);
11931194
}
11941195

11951196
static void rzg2l_gpio_irq_enable(struct irq_data *d)

0 commit comments

Comments
 (0)