Skip to content

Commit dd508e3

Browse files
CounterPillowbroonie
authored andcommitted
ASoC: rk3328: fix disabling mclk on pclk probe failure
If preparing/enabling the pclk fails, the probe function should unprepare and disable the previously prepared and enabled mclk, which it doesn't do. This commit rectifies this. Fixes: c327590 ("ASoC: rockchip: support ACODEC for rk3328") Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com> Reviewed-by: Katsuhiro Suzuki <katsuhiro@katsuster.net> Link: https://lore.kernel.org/r/20220427172310.138638-1-frattaroli.nicolas@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 7e0bdba commit dd508e3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/codecs/rk3328_codec.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ static int rk3328_platform_probe(struct platform_device *pdev)
481481
ret = clk_prepare_enable(rk3328->pclk);
482482
if (ret < 0) {
483483
dev_err(&pdev->dev, "failed to enable acodec pclk\n");
484-
return ret;
484+
goto err_unprepare_mclk;
485485
}
486486

487487
base = devm_platform_ioremap_resource(pdev, 0);

0 commit comments

Comments
 (0)