Skip to content

Commit dddb019

Browse files
aloktiwakuba-moo
authored andcommitted
net: marvell: prestera: fix FEC error message for SFP ports
In prestera_ethtool_set_fecparam(), the error message is opposite of the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is not allowed on SFP ports, but the message says "non-SFP ports", which does not match the condition. However, FEC may be required depending on the transceiver, cable, or mode, and firmware already validates invalid combinations. Remove the SFP transceiver check and let firmware handle validation. Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Acked-by: Elad Nachman <enachman@marvell.com> Link: https://patch.msgid.link/20260205091958.231413-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 2214aab commit dddb019

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

drivers/net/ethernet/marvell/prestera/prestera_ethtool.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -717,11 +717,6 @@ static int prestera_ethtool_set_fecparam(struct net_device *dev,
717717
return -EINVAL;
718718
}
719719

720-
if (port->caps.transceiver == PRESTERA_PORT_TCVR_SFP) {
721-
netdev_err(dev, "FEC set is not allowed on non-SFP ports\n");
722-
return -EINVAL;
723-
}
724-
725720
fec = PRESTERA_PORT_FEC_MAX;
726721
for (mode = 0; mode < PRESTERA_PORT_FEC_MAX; mode++) {
727722
if ((port_fec_caps[mode].eth_fec & fecparam->fec) &&

0 commit comments

Comments
 (0)