Skip to content

Commit de00d07

Browse files
Fuad TabbaMarc Zyngier
authored andcommitted
KVM: selftests: Move page_align() to shared header
To avoid code duplication, move page_align() to the shared `kvm_util.h` header file. Rename it to vm_page_align(), to make it clear that the alignment is done with respect to the guest's base page size. No functional change intended. Reviewed-by: Andrew Jones <andrew.jones@linux.dev> Signed-off-by: Fuad Tabba <tabba@google.com> Link: https://patch.msgid.link/20260109082218.3236580-5-tabba@google.com Signed-off-by: Marc Zyngier <maz@kernel.org>
1 parent 582b394 commit de00d07

3 files changed

Lines changed: 7 additions & 12 deletions

File tree

tools/testing/selftests/kvm/include/kvm_util.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1258,6 +1258,11 @@ static inline int __vm_disable_nx_huge_pages(struct kvm_vm *vm)
12581258
return __vm_enable_cap(vm, KVM_CAP_VM_DISABLE_NX_HUGE_PAGES, 0);
12591259
}
12601260

1261+
static inline uint64_t vm_page_align(struct kvm_vm *vm, uint64_t v)
1262+
{
1263+
return (v + vm->page_size - 1) & ~(vm->page_size - 1);
1264+
}
1265+
12611266
/*
12621267
* Arch hook that is invoked via a constructor, i.e. before exeucting main(),
12631268
* to allow for arch-specific setup that is common to all tests, e.g. computing

tools/testing/selftests/kvm/lib/arm64/processor.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@
2121

2222
static vm_vaddr_t exception_handlers;
2323

24-
static uint64_t page_align(struct kvm_vm *vm, uint64_t v)
25-
{
26-
return (v + vm->page_size - 1) & ~(vm->page_size - 1);
27-
}
28-
2924
static uint64_t pgd_index(struct kvm_vm *vm, vm_vaddr_t gva)
3025
{
3126
unsigned int shift = (vm->pgtable_levels - 1) * (vm->page_shift - 3) + vm->page_shift;
@@ -115,7 +110,7 @@ static uint64_t __maybe_unused ptrs_per_pte(struct kvm_vm *vm)
115110

116111
void virt_arch_pgd_alloc(struct kvm_vm *vm)
117112
{
118-
size_t nr_pages = page_align(vm, ptrs_per_pgd(vm) * 8) / vm->page_size;
113+
size_t nr_pages = vm_page_align(vm, ptrs_per_pgd(vm) * 8) / vm->page_size;
119114

120115
if (vm->pgd_created)
121116
return;

tools/testing/selftests/kvm/lib/riscv/processor.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ bool __vcpu_has_ext(struct kvm_vcpu *vcpu, uint64_t ext)
2626
return !ret && !!value;
2727
}
2828

29-
static uint64_t page_align(struct kvm_vm *vm, uint64_t v)
30-
{
31-
return (v + vm->page_size - 1) & ~(vm->page_size - 1);
32-
}
33-
3429
static uint64_t pte_addr(struct kvm_vm *vm, uint64_t entry)
3530
{
3631
return ((entry & PGTBL_PTE_ADDR_MASK) >> PGTBL_PTE_ADDR_SHIFT) <<
@@ -68,7 +63,7 @@ static uint64_t pte_index(struct kvm_vm *vm, vm_vaddr_t gva, int level)
6863

6964
void virt_arch_pgd_alloc(struct kvm_vm *vm)
7065
{
71-
size_t nr_pages = page_align(vm, ptrs_per_pte(vm) * 8) / vm->page_size;
66+
size_t nr_pages = vm_page_align(vm, ptrs_per_pte(vm) * 8) / vm->page_size;
7267

7368
if (vm->pgd_created)
7469
return;

0 commit comments

Comments
 (0)