thermal/drivers/qcom/tsens: Init debugfs only with successful probe

Ansuel · Daniel Lezcano · commit de48d8766afc · 2022-12-14T15:25:40.000+01:00
Calibrate and tsens_register can fail or PROBE_DEFER. This will cause a double or a wrong init of the debugfs information. Init debugfs only with successful probe fixing warning about directory already present. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Acked-by: Thara Gopinath <thara.gopinath@linaro.org> Link: https://lore.kernel.org/r/20221022125657.22530-2-ansuelsmth@gmail.com Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
@@ -939,8 +939,6 @@ int __init init_common(struct tsens_priv *priv)
 	if (tsens_version(priv) >= VER_0_1)
 		tsens_enable_irq(priv);
 
-	tsens_debug_init(op);
-
 err_put_device:
 	put_device(&op->dev);
 	return ret;
@@ -1182,7 +1180,11 @@ static int tsens_probe(struct platform_device *pdev)
 		}
 	}
 
-	return tsens_register(priv);
+	ret = tsens_register(priv);
+	if (!ret)
+		tsens_debug_init(pdev);
+
+	return ret;
 }
 
 static int tsens_remove(struct platform_device *pdev)

Original file line number	Diff line number	Diff line change
`@@ -939,8 +939,6 @@ int __init init_common(struct tsens_priv *priv)`
`939`	`939`	`if (tsens_version(priv) >= VER_0_1)`
`940`	`940`	`tsens_enable_irq(priv);`
`941`	`941`
`942`		`- tsens_debug_init(op);`
`943`		`-`
`944`	`942`	`err_put_device:`
`945`	`943`	`put_device(&op->dev);`
`946`	`944`	`return ret;`
`@@ -1182,7 +1180,11 @@ static int tsens_probe(struct platform_device *pdev)`
`1182`	`1180`	`}`
`1183`	`1181`	`}`
`1184`	`1182`
`1185`		`- return tsens_register(priv);`
	`1183`	`+ ret = tsens_register(priv);`
	`1184`	`+ if (!ret)`
	`1185`	`+ tsens_debug_init(pdev);`
	`1186`	`+`
	`1187`	`+ return ret;`
`1186`	`1188`	`}`
`1187`	`1189`
`1188`	`1190`	`static int tsens_remove(struct platform_device *pdev)`