Skip to content

Commit de50a7e

Browse files
diederikdehaasmmind
authored andcommitted
arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328
The "synopsys,dw-hdmi.yaml" binding specifies that the interrupts property of the hdmi node has 'maxItems: 1', so the hdmi node in rk3328.dtsi having 2 is incorrect. Paragraph 1.3 ("System Interrupt connection") of the RK3328 TRM v1.1 page 16 and 17 define the following hdmi related interrupts: - 67 hdmi_intr - 103 hdmi_intr_wakeup The difference of 32 is due to a different base used in the TRM. The RK3399 (which uses the same binding) has '23: hdmi_irq' and '24: hdmi_wakeup_irq' according to its TRM (page 19). The RK3568 (also same binding) has '76: hdmi_wakeup' and '77: hdmi' according to page 17 of its TRM. In both cases the non-wakeup IRQ was used, so use that too for rk3328. Helped-by: Heiko Stuebner <heiko@sntech.de> Fixes: 725e351 ("arm64: dts: rockchip: add rk3328 display nodes") Signed-off-by: Diederik de Haas <didi.debian@cknow.org> Link: https://lore.kernel.org/r/20241008113344.23957-3-didi.debian@cknow.org Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 875ea82 commit de50a7e

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3328.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -754,8 +754,7 @@
754754
compatible = "rockchip,rk3328-dw-hdmi";
755755
reg = <0x0 0xff3c0000 0x0 0x20000>;
756756
reg-io-width = <4>;
757-
interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
758-
<GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
757+
interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
759758
clocks = <&cru PCLK_HDMI>,
760759
<&cru SCLK_HDMI_SFC>,
761760
<&cru SCLK_RTC32K>;

0 commit comments

Comments
 (0)